Re: mdocml version 1.12.0 available

["Ulrich Spörlein" <uqs@spoerlein.net>]

On Thu, 2011-10-13 at 02:50:45 +0200, Ingo Schwarze wrote:
> Hi Joerg,
> 
> Joerg Sonnenberger wrote on Tue, Oct 11, 2011 at 04:56:41PM +0200:
> 
> > Attached is the report from clang -analyze. Food for thought ;)
> 
> Thanks for sending these.
> Below is a patch to improve style at a few places,
> none of these are bugs, though.
> No regressions according to my tests.
> 
> A few more reports are valid, but i suggest to keep those redundant
> initializations because it is non-trivial to figure out that all
> branches actually set a value, so it's safer to initialize up
> front, especially in view of potential future code changes.
> 
> Two complaints might be bogus:
> 
> > /home/joerg/work/NetBSD/cvs/src/external/bsd/mdocml/bin/mandoc/../../dist/mdoc_term.c:617:7: warning: Access to field 'prev' results in a dereference of a null pointer (loaded from variable 'n')
> >                 if (n->prev && MDOC_It == n->prev->tok) {
> >                     ^
> > /home/joerg/work/NetBSD/cvs/src/external/bsd/mdocml/bin/mandoc/../../dist/mdoc_term.c:611:7: warning: Access to field 'prev' results in a dereference of a null pointer (loaded from variable 'n')
> >                 if (n->prev && MDOC_It == n->prev->tok)
> >                     ^
> 
> I have no idea why clang thinks n might be NULL here.
> Do you understand that?
> Or is this just a false positive?

print_bvspace could have been called with n being NULL. Perhaps the HTML
report is little bit more helpful:
https://www.spoerlein.net/scan-build/mdocml/2011-10-13-1/report-qHe1Tf.html#EndPath

hth
Uli
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv