Re: do not reformat man(7)-style dates

[Ingo Schwarze <schwarze@usta.de>]

Hi Kristaps,

Kristaps Dzonsons wrote on Thu, Nov 03, 2011 at 04:35:08PM +0100:
> Ingo Schwarze wrote:

>>Index: mandoc.c
>>===================================================================
>>RCS file: /cvs/src/usr.bin/mandoc/mandoc.c,v
>>retrieving revision 1.29
>>diff -u -p -r1.29 mandoc.c
>>--- mandoc.c	24 Oct 2011 20:29:21 -0000	1.29
>>+++ mandoc.c	1 Nov 2011 16:26:24 -0000
>>@@ -609,9 +609,10 @@ mandoc_normdate(struct mparse *parse, ch
>>  		mandoc_msg(MANDOCERR_NODATE, parse, ln, pos, NULL);
>>  		time(&t);
>>  	}
>>+	else if (a2time(&t, "%Y-%m-%d", in))
>>+		t = 0;
>>  	else if (!a2time(&t, "$" "Mdocdate: %b %d %Y $", in)&&
>>-	    !a2time(&t, "%b %d, %Y", in)&&
>>-	    !a2time(&t, "%Y-%m-%d", in)) {
>>+	    !a2time(&t, "%b %d, %Y", in)) {
>>  		mandoc_msg(MANDOCERR_BADDATE, parse, ln, pos, NULL);
>>  		t = 0;
>>  	}

> Isn't it easier just to do as in the enclosed patch?

Even though your patch is much larger than mine,
the resulting code is slightly simpler; granted.

> man(7) doesn't seem to care at all about the date, so let's stop
> pretending that it does and just mandoc_strdup() instead of
> mandoc_normdate().

Still, i don't like that approach.  Even if groff does not care,
i'd still like to provide a WARNING if somebody puts

  "Febuary 30, 2o11"   \" note: three typos
  "20l1_31_12"         \" note: three errors

into a man(7) document.

Thus, i prefer my patch.

Yours,
  Ingo
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv