Re: mdocml: Have exprcomp() accept a string instead of an array-pointer.

[Ingo Schwarze <schwarze@usta.de>]

Hi Kristaps,

oh well, i must have been asleep when looking at this yesterday;
sorry for providing a premature OK.  I just realized then following
when doing final tests before committing the merge to OpenBSD.

Isn't this going to break the difference between

  apropos UNIX manual

(which is supposed to search for all pages containing at least one
of the strings "UNIX" or "manual" in Nm or Nd), and

  apropos "UNIX manual"

(which is supposed to search for those containing "UNIX manual"
as one single string)?

And look here:

  $ apropos " .h "
  h2ph (1) - convert .h C header files to .ph Perl header files
  h2xs (1) - convert .h C header files to Perl extensions
  ischwarze@isnote $ apropos .h | wc -l
    11

How are you going to preserve these differences?

Is it really required to throw away the argument splitting done
by the shell, then start over, potentially breaking all the
quoting?

I'm holding off on the merge for a minute...
Maybe this has to be reverted?  :-(

Yours,
  Ingo

P.S.
Besides, you missed my small fix regarding trailing blanks.


kristaps@mdocml.bsd.lv wrote on Mon, Nov 14, 2011 at 05:07:06AM -0500:

> Log Message:
> -----------
> Have exprcomp() accept a string instead of an array-pointer.  Also, collapse
> the arguments in apropos(1) into a single string passed to exprcomp().  Ok
> schwarze@.
> 
> Modified Files:
> --------------
>     mdocml:
>         apropos.c
>         apropos_db.c
>         apropos_db.h
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv