From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from scc-mailout.scc.kit.edu (scc-mailout.scc.kit.edu [129.13.185.202]) by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id pAKCRBVk019312 for ; Sun, 20 Nov 2011 07:27:12 -0500 (EST) Received: from hekate.usta.de (asta-nat.asta.uni-karlsruhe.de [172.22.63.82]) by scc-mailout-02.scc.kit.edu with esmtp (Exim 4.72 #1) id 1RS6UI-0001ab-6j; Sun, 20 Nov 2011 13:27:10 +0100 Received: from donnerwolke.usta.de ([172.24.96.3]) by hekate.usta.de with esmtp (Exim 4.72) (envelope-from ) id 1RS6UI-0002zx-B7; Sun, 20 Nov 2011 13:27:10 +0100 Received: from iris.usta.de ([172.24.96.5] helo=usta.de) by donnerwolke.usta.de with esmtp (Exim 4.72) (envelope-from ) id 1RS6UI-000734-AF; Sun, 20 Nov 2011 13:27:10 +0100 Received: from schwarze by usta.de with local (Exim 4.72) (envelope-from ) id 1RS6UI-0004XD-9H; Sun, 20 Nov 2011 13:27:10 +0100 Date: Sun, 20 Nov 2011 13:27:10 +0100 From: Ingo Schwarze To: Joerg Sonnenberger Cc: tech@mdocml.bsd.lv Subject: Re: mdocml: Convert an assert into an explicit check. Message-ID: <20111120122710.GB31954@iris.usta.de> References: <201111181639.pAIGd8Y3022061@krisdoz.my.domain> <20111119141907.GC28954@iris.usta.de> <20111120042512.GD16040@britannica.bec.de> <20111120042644.GE16040@britannica.bec.de> X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111120042644.GE16040@britannica.bec.de> User-Agent: Mutt/1.5.21 (2010-09-15) Hi Joerg, Joerg Sonnenberger wrote on Sun, Nov 20, 2011 at 05:26:44AM +0100: > On Sun, Nov 20, 2011 at 05:25:12AM +0100, Joerg Sonnenberger wrote: >> On Sat, Nov 19, 2011 at 03:19:07PM +0100, Ingo Schwarze wrote: >>> joerg@mdocml.bsd.lv wrote on Fri, Nov 18, 2011 at 11:39:08AM -0500: >>>> Log Message: >>>> ----------- >>>> Convert an assert into an explicit check. man_unscope can be triggered >>>> on unknown macros. >>>> >>>> Modified Files: >>>> -------------- >>>> mdocml: >>>> man_macro.c >>> Sorry, so far i failed to reproduce the problem. >>> Can you provide an example? >> .ab help2man is required to generate this page >> >> was the case that originally triggered this. > I think this also triggers the other case with missing default settings > in man_term.c later. Oh, now i see. It's not mandoc(1) that is crashing on that one, but groff(1); the .ab request means "abort". Sure, .ab is ignored by mandoc, but when you run a unit test with both groff and mandoc on a file containing .ab, the test fails because groff fails. Obviously, you have mistaken that for a mandoc failure. So please back out both bogus patches, unless you can demonstrate that there is a problem with mandoc. The following two test files both work for me with mandoc and both abort with groff. Commenting out any number of .TH arguments, or the whole .TH line, doesn't reveal any problems either. Yours, Ingo ischwarze@isnote $ cat badbefore.in .ab help2man is required to generate this page .TH TH-BADBEFORE 1 "November 19, 2011" .SH NAME TH-badbefore \- unknown macro before .TH .SH DESCRIPTION Some text. ischwarze@isnote $ cat badafter.in .TH TH-BADAFTER 1 "November 19, 2011" .ab help2man is required to generate this page .SH NAME TH-badafter \- unknown macro after .TH .SH DESCRIPTION Some text. ischwarze@isnote $ mandoc badbefore.in > /dev/null && echo ok ok ischwarze@isnote $ mandoc badafter.in > /dev/null && echo ok ok ischwarze@isnote $ /usr/local/bin/nroff -mandoc -Tascii -c badbefore.in help2man is required to generate this page ischwarze@isnote $ /usr/local/bin/nroff -mandoc -Tascii -c badafter.in TH-BADAFTER(1) TH-BADAFTER(1) help2man is required to generate this page -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv