From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from scc-mailout.scc.kit.edu (scc-mailout.scc.kit.edu [129.13.185.202]) by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id pAKCbLVb022045 for ; Sun, 20 Nov 2011 07:37:21 -0500 (EST) Received: from hekate.usta.de (asta-nat.asta.uni-karlsruhe.de [172.22.63.82]) by scc-mailout-02.scc.kit.edu with esmtp (Exim 4.72 #1) id 1RS6e9-0003UO-2Y; Sun, 20 Nov 2011 13:37:21 +0100 Received: from donnerwolke.usta.de ([172.24.96.3]) by hekate.usta.de with esmtp (Exim 4.72) (envelope-from ) id 1RS6e8-0007Iy-Vu for tech@mdocml.bsd.lv; Sun, 20 Nov 2011 13:37:20 +0100 Received: from iris.usta.de ([172.24.96.5] helo=usta.de) by donnerwolke.usta.de with esmtp (Exim 4.72) (envelope-from ) id 1RS6e8-00075X-Up for tech@mdocml.bsd.lv; Sun, 20 Nov 2011 13:37:20 +0100 Received: from schwarze by usta.de with local (Exim 4.72) (envelope-from ) id 1RS6e8-0002XP-Tt for tech@mdocml.bsd.lv; Sun, 20 Nov 2011 13:37:20 +0100 Date: Sun, 20 Nov 2011 13:37:20 +0100 From: Ingo Schwarze To: tech@mdocml.bsd.lv Subject: Re: mdocml: Bail out explicitly on invalid .Rs content like: .Rs plain text Message-ID: <20111120123720.GC31954@iris.usta.de> References: <201111181458.pAIEwOCM016755@krisdoz.my.domain> <20111119133220.GB28954@iris.usta.de> <20111120042741.GF16040@britannica.bec.de> X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111120042741.GF16040@britannica.bec.de> User-Agent: Mutt/1.5.21 (2010-09-15) Hi Joerg, Joerg Sonnenberger wrote on Sun, Nov 20, 2011 at 05:27:41AM +0100: > On Sat, Nov 19, 2011 at 02:32:20PM +0100, Ingo Schwarze wrote: >> i could confirm both the problem and the fix, and i don't see any >> regressions, so i have merged this to OpenBSD and improved the >> comment a bit. > There is one aspect to consider. We drop > .Rs > plain text > .Re > silently now, when groff renders it. Sure, i have a test case for that in my private collection of failing test cases. If anybody considers it of sufficient importance, feel free to add it to TODO. Typically, i add stuff to TODO when i see a case in practice where it matters, and i haven't yet seen one involving plain text in .Rs. ischwarze@isnote $ cd /usr/src/regress/usr.bin/mandoc/TODO/ ischwarze@isnote $ find . -name '*.in' | wc -l 98 For the time being, your patch prevents a crash, which is already a real improvement. Yours, Ingo -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv