Re: put back the chdir(2) in mandocdb(8)

[Ingo Schwarze <schwarze@usta.de>]

Hi Kristaps,

Kristaps Dzonsons wrote on Mon, Nov 28, 2011 at 09:40:23AM +0100:
> On 28/11/2011 02:09, Ingo Schwarze wrote:

>> Put back the chdir(2) to the right man page tree before parsing manuals;
>> this got lost during the bsd.lv sync in rev. 1.10; oops.
>> This is required for processing .so links: otherwise, several files
>> in Xenocara fail to parse and cause ugly complaints instead.

> Yes, please do.
> However, can you add a little explanation for the chdir()

Yes.

> and check its return value?

No.

OK?
  Ingo


Index: mandocdb.c
===================================================================
RCS file: /cvs/src/usr.bin/mandoc/mandocdb.c,v
retrieving revision 1.14
diff -u -p -r1.14 mandocdb.c
--- mandocdb.c	28 Nov 2011 00:57:28 -0000	1.14
+++ mandocdb.c	28 Nov 2011 10:04:58 -0000
@@ -375,6 +375,12 @@ mandocdb(int argc, char *argv[])
 		index_prune(of, db, fbuf, idx, ibuf,
 				&maxrec, &recs, &recsz);
 
+		/*
+		 * Go to the root of the respective manual tree
+		 * such that .so links work.  In case of failure,
+		 * just prod on, even though .so links won't work.
+		 */
+
 		if (OP_UPDATE == op) {
 			chdir(dir);
 			index_merge(of, mp, &dbuf, &buf, hash,
@@ -448,6 +454,12 @@ mandocdb(int argc, char *argv[])
 			continue;
 
 		of = of->first;
+
+		/*
+		 * Go to the root of the respective manual tree
+		 * such that .so links work.  In case of failure,
+		 * just prod on, even though .so links won't work.
+		 */
 
 		chdir(dirs.paths[i]);
 		index_merge(of, mp, &dbuf, &buf, hash, db, fbuf,
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv