From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mo-p00-ob.rzone.de (mo-p00-ob.rzone.de [81.169.146.161]) by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id pB40GEDp013020 for ; Sat, 3 Dec 2011 19:16:14 -0500 (EST) X-RZG-AUTH: :JiIXek6mfvEEUpFQdo7Fj1/zg48CFjWjQv0cW+St/nW/auYssS93lrRBFRi9Ng== X-RZG-CLASS-ID: mo00 Received: from britannica.bec.de (ip-2-202-153-54.web.vodafone.de [2.202.153.54]) by smtp.strato.de (klopstock mo35) (RZmta 26.10 AUTH) with (DHE-RSA-AES128-SHA encrypted) ESMTPA id a04a39nB3Kb0Vv for ; Sun, 4 Dec 2011 01:15:52 +0100 (MET) Received: by britannica.bec.de (sSMTP sendmail emulation); Sun, 04 Dec 2011 01:15:50 +0100 Date: Sun, 4 Dec 2011 01:15:50 +0100 From: Joerg Sonnenberger To: tech@mdocml.bsd.lv Subject: Re: mdocml: Convert an assert into an explicit check. Message-ID: <20111204001550.GA7754@britannica.bec.de> Mail-Followup-To: tech@mdocml.bsd.lv References: <201111181639.pAIGd8Y3022061@krisdoz.my.domain> <20111119141907.GC28954@iris.usta.de> <20111120042512.GD16040@britannica.bec.de> <20111120042644.GE16040@britannica.bec.de> <20111120122710.GB31954@iris.usta.de> <20111120191718.GA24971@britannica.bec.de> <20111203214157.GH17667@iris.usta.de> <20111203224755.GC3697@britannica.bec.de> <20111203235005.GL17667@iris.usta.de> X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111203235005.GL17667@iris.usta.de> User-Agent: Mutt/1.5.21 (2010-09-15) On Sun, Dec 04, 2011 at 12:50:05AM +0100, Ingo Schwarze wrote: > Hi Joerg, > > Joerg Sonnenberger wrote on Sat, Dec 03, 2011 at 11:47:55PM +0100: > > On Sat, Dec 03, 2011 at 10:41:57PM +0100, Ingo Schwarze wrote: > > >> That function just works fine even when the syntax tree is completely > >> empty, only containing the ROOT node. It is important to *NOT* > >> return early, but to continue through the whole function and execute > >> the man_valid_post(m) near the end - otherwise, you will end up > >> with NULL pointers in the meta structure and provoke the crashes > >> you observed. > > > In that case at least assert that m->title etc are not NULL. > > Sure, that's not going to do harm. > > OK? OK. Joerg -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv