tech@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: Ingo Schwarze <schwarze@usta.de>
To: tech@mdocml.bsd.lv
Cc: uqs@spoerlein.net
Subject: Re: [patch] fix wrong argument for calloc
Date: Sat, 18 May 2013 18:45:45 +0200	[thread overview]
Message-ID: <20130518164545.GC30629@iris.usta.de> (raw)
In-Reply-To: <20130517002910.GX2055@acme.spoerlein.net>

Hi Ulrich,

Ulrich Spörlein wrote on Fri, May 17, 2013 at 02:29:10AM +0200:

> simple patch, please commit.

Done, both to bsd.lv and openbsd.org.

> This was found by Coverity Scan CID 978734,

Hummm...  Please bear with my ignorance...
How can anybody do anything with the CID?
Is the CID really useful without a project ID?
Is there a database somewhere on the net?

> please mention that in the commit message.

Done so, too.

Thanks,
  Ingo

> Index: chars.c
> ===================================================================
> RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/chars.c,v
> retrieving revision 1.52
> diff -u -p -r1.52 chars.c
> --- chars.c	8 Nov 2011 00:15:23 -0000	1.52
> +++ chars.c	17 May 2013 00:17:18 -0000
> @@ -77,7 +77,7 @@ mchars_alloc(void)
>  	 */
>  
>  	tab = mandoc_malloc(sizeof(struct mchars));
> -	htab = mandoc_calloc(PRINT_HI - PRINT_LO + 1, sizeof(struct ln **));
> +	htab = mandoc_calloc(PRINT_HI - PRINT_LO + 1, sizeof(struct ln *));
>  
>  	for (i = 0; i < LINES_MAX; i++) {
>  		hash = (int)lines[i].code[0] - PRINT_LO;
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv

  reply	other threads:[~2013-05-18 16:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17  0:29 Ulrich Spörlein
2013-05-18 16:45 ` Ingo Schwarze [this message]
2013-05-19  1:58   ` Ulrich Spörlein
2013-05-19 16:11     ` Ingo Schwarze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130518164545.GC30629@iris.usta.de \
    --to=schwarze@usta.de \
    --cc=tech@mdocml.bsd.lv \
    --cc=uqs@spoerlein.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).