From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout.scc.kit.edu (mailout.scc.kit.edu [129.13.185.202]) by krisdoz.my.domain (8.14.5/8.14.5) with ESMTP id r4IGjmX3021675 for ; Sat, 18 May 2013 12:45:48 -0400 (EDT) Received: from hekate.usta.de (asta-nat.asta.uni-karlsruhe.de [172.22.63.82]) by scc-mailout-02.scc.kit.edu with esmtp (Exim 4.72 #1) id 1UdkGQ-0007Cc-Qw; Sat, 18 May 2013 18:45:46 +0200 Received: from donnerwolke.usta.de ([172.24.96.3]) by hekate.usta.de with esmtp (Exim 4.77) (envelope-from ) id 1UdkGQ-00009L-QN; Sat, 18 May 2013 18:45:46 +0200 Received: from iris.usta.de ([172.24.96.5] helo=usta.de) by donnerwolke.usta.de with esmtp (Exim 4.72) (envelope-from ) id 1UdkGQ-0003nT-PH; Sat, 18 May 2013 18:45:46 +0200 Received: from schwarze by usta.de with local (Exim 4.77) (envelope-from ) id 1UdkGQ-00065g-8Q; Sat, 18 May 2013 18:45:46 +0200 Date: Sat, 18 May 2013 18:45:45 +0200 From: Ingo Schwarze To: tech@mdocml.bsd.lv Cc: uqs@spoerlein.net Subject: Re: [patch] fix wrong argument for calloc Message-ID: <20130518164545.GC30629@iris.usta.de> References: <20130517002910.GX2055@acme.spoerlein.net> X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130517002910.GX2055@acme.spoerlein.net> User-Agent: Mutt/1.5.21 (2010-09-15) Hi Ulrich, Ulrich Spörlein wrote on Fri, May 17, 2013 at 02:29:10AM +0200: > simple patch, please commit. Done, both to bsd.lv and openbsd.org. > This was found by Coverity Scan CID 978734, Hummm... Please bear with my ignorance... How can anybody do anything with the CID? Is the CID really useful without a project ID? Is there a database somewhere on the net? > please mention that in the commit message. Done so, too. Thanks, Ingo > Index: chars.c > =================================================================== > RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/chars.c,v > retrieving revision 1.52 > diff -u -p -r1.52 chars.c > --- chars.c 8 Nov 2011 00:15:23 -0000 1.52 > +++ chars.c 17 May 2013 00:17:18 -0000 > @@ -77,7 +77,7 @@ mchars_alloc(void) > */ > > tab = mandoc_malloc(sizeof(struct mchars)); > - htab = mandoc_calloc(PRINT_HI - PRINT_LO + 1, sizeof(struct ln **)); > + htab = mandoc_calloc(PRINT_HI - PRINT_LO + 1, sizeof(struct ln *)); > > for (i = 0; i < LINES_MAX; i++) { > hash = (int)lines[i].code[0] - PRINT_LO; -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv