tech@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: Ingo Schwarze <schwarze@usta.de>
To: tech@mdocml.bsd.lv
Cc: "Anthony J. Bentley" <anthony@cathet.us>
Subject: Re: Use pretty quotes with %T
Date: Thu, 6 Nov 2014 03:52:15 +0100	[thread overview]
Message-ID: <20141106025215.GC19471@iris.usta.de> (raw)
In-Reply-To: <21337.1415237211@cathet.us>

Hi Anthony,

Anthony J. Bentley wrote on Wed, Nov 05, 2014 at 06:26:51PM -0700:

> Currently %T wraps reference titles in straight double quotes. It makes
> more sense to match Dq.

Arguably, that's slightly nicer, but i don't think we should change
this unilaterally in mandoc.  If you think it's worth it and manage
to push the change to both groff and Heirloom (but please make sure
that either both of them or none change it, making them disagree
with each other wouldn't seem an improvement to me) then i will
follow with mandoc.

Yours,
  Ingo


> Index: mdoc_term.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/mandoc/mdoc_term.c,v
> retrieving revision 1.187
> diff -u -p -u -p -r1.187 mdoc_term.c
> --- mdoc_term.c	30 Oct 2014 20:05:33 -0000	1.187
> +++ mdoc_term.c	6 Nov 2014 01:24:58 -0000
> @@ -1866,6 +1866,8 @@ termp_quote_pre(DECL_ARGS)
>  	case MDOC_Bq:
>  		term_word(p, "[");
>  		break;
> +	case MDOC__T:
> +		/* FALLTHROUGH */
>  	case MDOC_Do:
>  		/* FALLTHROUGH */
>  	case MDOC_Dq:
> @@ -1884,8 +1886,6 @@ termp_quote_pre(DECL_ARGS)
>  	case MDOC_Pq:
>  		term_word(p, "(");
>  		break;
> -	case MDOC__T:
> -		/* FALLTHROUGH */
>  	case MDOC_Qo:
>  		/* FALLTHROUGH */
>  	case MDOC_Qq:
> @@ -1937,6 +1937,8 @@ termp_quote_post(DECL_ARGS)
>  	case MDOC_Bq:
>  		term_word(p, "]");
>  		break;
> +	case MDOC__T:
> +		/* FALLTHROUGH */
>  	case MDOC_Do:
>  		/* FALLTHROUGH */
>  	case MDOC_Dq:
> @@ -1957,8 +1959,6 @@ termp_quote_post(DECL_ARGS)
>  	case MDOC_Pq:
>  		term_word(p, ")");
>  		break;
> -	case MDOC__T:
> -		/* FALLTHROUGH */
>  	case MDOC_Qo:
>  		/* FALLTHROUGH */
>  	case MDOC_Qq:
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv

      reply	other threads:[~2014-11-06  2:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06  1:26 Anthony J. Bentley
2014-11-06  2:52 ` Ingo Schwarze [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141106025215.GC19471@iris.usta.de \
    --to=schwarze@usta.de \
    --cc=anthony@cathet.us \
    --cc=tech@mdocml.bsd.lv \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).