From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from scc-mailout-kit-01-web.scc.kit.edu (scc-mailout-kit-01-web.scc.kit.edu [129.13.231.93]); by fantadrom.bsd.lv (OpenSMTPD) with ESMTP id c4893c07; for ; Fri, 20 Mar 2015 11:35:37 -0500 (EST) Received: from asta-nat.asta.uni-karlsruhe.de ([172.22.63.82] helo=hekate.usta.de) by scc-mailout-kit-01.scc.kit.edu with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (envelope-from ) id 1YYztX-0005aH-BD; Fri, 20 Mar 2015 17:35:36 +0100 Received: from donnerwolke.usta.de ([172.24.96.3]) by hekate.usta.de with esmtp (Exim 4.77) (envelope-from ) id 1YYztX-0000zR-6O; Fri, 20 Mar 2015 17:35:35 +0100 Received: from athene.usta.de ([172.24.96.10]) by donnerwolke.usta.de with esmtp (Exim 4.80) (envelope-from ) id 1YYztX-00041q-1r; Fri, 20 Mar 2015 17:35:35 +0100 Received: from localhost (1031@localhost [local]); by localhost (OpenSMTPD) with ESMTPA id 285b4f46; Fri, 20 Mar 2015 17:35:35 +0100 (CET) Date: Fri, 20 Mar 2015 17:35:34 +0100 From: Ingo Schwarze To: Christian Neukirchen Cc: tech@mdocml.bsd.lv Subject: Re: mdocml fix for .PD Message-ID: <20150320163534.GD27243@athene.usta.de> References: <87zj786jxn.fsf@gmail.com> X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zj786jxn.fsf@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Hi Christian, Christian Neukirchen wrote on Fri, Mar 20, 2015 at 11:29:40AM +0100: > I'm not exactly sure about the semantics of .PD, but applying the > following That patch is clearly wrong. For example, it breaks the following OpenBSD regression test: /usr/src/regress/usr.bin/mandoc/man/PD/nextline.in Basically, it breaks anything that contains .PD after .TP or .TP after .SH or .SS without arguments, that is, .TP after the block macros that can have next-line head scope. The .PD macro is _not_ supposed to break block scope. > affects 29 of 12419 manpages on my system, and in each case > the new version looks as it's meant to be. It now renders like > Groff 1.22.3 and Plan9 nroff. > > In particular this fixes: > > cscope.1 gawk.1 ksh.1 qrencode.1 tcsh.1 xargs.1 zip.1 zipcloak.1 zsh.1 > zshall.1 zshbuiltins.1 zshcalsys.1 zshcompctl.1 zshcompsys.1 > zshcompwid.1 zshcontrib.1 zshexpn.1 zshmisc.1 zshmodules.1 > zshoptions.1 zshparam.1 zshroadmap.1 zshtcpsys.1 zshzftpsys.1 zshzle.1 > elf.5 nsswitch.conf.5 nmh.7 chcpu.8 I'm not sure which system you are talking about - some Linux? Is the problem with these pages still present in mandoc -HEAD, or is it fixed after my recent commit? Please make sure you have man_macro.c rev. 1.100 from mdocml.bsd.lv or man_macro.c rev. 1.62 from OpenBSD when retesting. Thanks, Ingo > --- man_macro.c 2015-03-13 13:38:38.000000000 +0100 > +++ man_macro.c 2015-03-19 23:20:11.786601197 +0100 > @@ -79,7 +79,7 @@ > { blk_exp, MAN_BSCOPE | MAN_EXPLICIT }, /* RS */ > { in_line_eoln, 0 }, /* DT */ > { in_line_eoln, 0 }, /* UC */ > - { in_line_eoln, 0 }, /* PD */ > + { in_line_eoln, MAN_BSCOPE }, /* PD */ > { in_line_eoln, 0 }, /* AT */ > { in_line_eoln, 0 }, /* in */ > { in_line_eoln, 0 }, /* ft */ -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv