From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf0-f54.google.com (mail-lf0-f54.google.com [209.85.215.54]) by fantadrom.bsd.lv (OpenSMTPD) with ESMTP id a1e65d29 for ; Fri, 5 Aug 2016 15:26:41 -0500 (EST) Received: by mail-lf0-f54.google.com with SMTP id g62so210934426lfe.3 for ; Fri, 05 Aug 2016 13:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EbS+Oh4S4W3KgG3w0K6uLsf7cYpiyEEkhjQbPXY23wI=; b=TptpvKY/0HveyNFRCZ/MHWB2FiX1zysJJ60wK1S2onUvDBSOzfA6/4Foi9JTO9i2TJ ACiUwxm6LGnxW3xVwNJJkx6V9ajKsZQXcTCKP7Wszyhz/jmUmXvVt5zf4LxZTF7dOchz zBQpvHxN3SyfoV52aFD9NTom44uDZqRxOj9PHL+zaoenaX6wzk+POV6oi3u6J5eJ373L D8Y8ulI3PlD/pS0XUb2blaG7R6uKIqGrv2xCNF0tc+mrHzlEjrRkqyeH2eglyT8WnNW/ Ewile1+TqHwgLZeCYZvVNHzJDPJ2l505znkMANGkqupvlKkr7BRvcliTcirs/tnfAvZp UzyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=EbS+Oh4S4W3KgG3w0K6uLsf7cYpiyEEkhjQbPXY23wI=; b=c9K1nI5PLGRGRoe90wIty0MH3IX+PuFk8oOm54F/pK4RP/yq1W6KIWjk4qCisWcU62 CCmWTq1WG91RW7bif2EL86ze3Ft4RelHHW7U3d6UeP7bJiJShalv1arOKTk0p33ITP7F V62sMBsvVZmO0FnFH0y75XwZycSx6+BO6DMeZGT2vjCUZymGLJGURAl6RnYyd6iinxaH qfFO6+wMRZRkJhT1MdioI9oG5ZKS3flVZ64hPQs8y8WspYAVvWFMt4wB/S4EDU0Bo8qr /lm9vrErk9hTaup/mzNUJDhsZ9HZehSs4ITmTWyX5GtG+db0i/yjuk1MjoXnFLjssrvI nPVw== X-Gm-Message-State: AEkoouvhqFHeCsXlf82cfHpNPjL3NHmjDVt+VvU4tEIsDyfuAjDzAka1OEqI4YxcSy2OCg== X-Received: by 10.25.44.84 with SMTP id s81mr21723149lfs.156.1470428799650; Fri, 05 Aug 2016 13:26:39 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id 192sm3447803ljf.17.2016.08.05.13.26.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Aug 2016 13:26:38 -0700 (PDT) Sender: Baptiste Daroussin Date: Fri, 5 Aug 2016 22:26:37 +0200 From: Baptiste Daroussin To: tech@mdocml.bsd.lv Subject: Re: New db format Message-ID: <20160805202637.zhscohdeupq5wguj@ivaldir.etoilebsd.net> References: <20160709131158.GA6629@athene.usta.de> <20160709133936.tr4zsiekmrbfuav2@ivaldir.etoilebsd.net> <97865.1468074718@CATHET.us> <20160709152926.42bre6tittzmpm2g@ivaldir.etoilebsd.net> <20160709161251.GD6629@athene.usta.de> X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6pc6aibr5hr3uabi" Content-Disposition: inline In-Reply-To: <20160709161251.GD6629@athene.usta.de> User-Agent: Mutt/1.6.2-neo (2016-07-23) --6pc6aibr5hr3uabi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 09, 2016 at 06:12:51PM +0200, Ingo Schwarze wrote: > Hi Baptiste, >=20 > Baptiste Daroussin FreeBSD wrote on Sat, Jul 09, 2016 at 05:29:27PM +0200: >=20 > > Beside minor portability issues (that I will provide fixes for once > > this patch is official) >=20 > You can already provide them now if you want to, and i'll include > them in my work-in-progress version and testing. >=20 > > I can say it works fine on FreeBSD :) > > Tested on FreeBSD 12-CURRENT: >=20 > Great to hear that. >=20 > My main worry is that i screwed alignment somewhere. Did you test > on any machines with unusual alignment requirements? Or is keeping > int32_t aligned to 4-byte boundaries guaranteed to be safe everywhere? >=20 > > The 3 main "bad" feedbacks I got about mandoc was: > > - time to create the db was long with sqlite with the new code > > it is longer: does from 4s to 11s in general for the base manpages > > but I do not consider that as a big issue given it is not run that > > often and the code is quite new and there are probably room of > > improvements >=20 > The SQLite version was optimized with gprof(1). I can try again > for the new code. But mandoc's makewhatis(8) will always remain > much slower than traditional makewhatis(8) because it parses the > complete manuals rather than just the NAME sections. After some profiling of the new code, it appears that most of the time is s= pent on dba_array_get and dba_array_next The flamegraph of makewhatis https://people.freebsd.org/~bapt/makewhatis.svg Best regards, Bapt --6pc6aibr5hr3uabi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXpPZ8AAoJEGOJi9zxtz5aY5YQANDvyI73T/HY3xzQwXtePsVA hk3r3kj65QHJZ7zoSh7meFHF2uAyZ1q0DVehJfeqr+/QBXUVjpcl/pb91Q3dwlDK j+ACSH3PZ6rVQ3xlxUxKb5jbb9Znoui8O19m7jTga+gywzI1yejP8vhjzOnTwclX hbSDyhbmYPfa50Tf5InqqP0KcYdm5nfI14Uu/scc/huxVpzJSnwpWD5gQlyI1NW+ de9CO1sgwYmCBhIi0Mu7q4yTnVzlZn0xqQTkoL0jYqEjeD61QnaOGdYvgnYo/YI4 MQ+9EcVRIt4LP7OSFwel5Fh9muGzMiH6uquD7NnF4zo4pi/f8pcWLKFOw4JuPRMK YFGti3Lh221Tjt1MOBcr8rilZ3YErZh1o54d7tBaoT6OAkkHQ4+FqKWRNO26c3Tq VAHF65lXGmea0gEpbiqlF/w13I+cgSPVn4d6cd8vAWHedw/is7y7QM1dV2s9HG/o 6+zLZ5SEe9ZNdbYaOjO+23t9J1YwTuISRJ9NhJ2wGPMAvvdXuHlgsX54sty+Ko0B TO8/TNMEE83UOkQFpKmjO3M84R67pkkARovBf+/xIHX+v73WYH6Z7VBJ9Qq+8DNW I7p/qHPBUTzNApshx2RrUjN/hw20sNsin/9r14LImg034CkdidCsgVdZJ97n7jDI BEIS7qpm1bbqVu7wi75C =020k -----END PGP SIGNATURE----- --6pc6aibr5hr3uabi-- -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv