From: Baptiste Daroussin <bapt@FreeBSD.org>
To: tech@mdocml.bsd.lv
Subject: Re: small portability issue
Date: Sat, 6 Aug 2016 01:36:39 +0200 [thread overview]
Message-ID: <20160805233639.grwxg4otpcoregeq@ivaldir.etoilebsd.net> (raw)
In-Reply-To: <20160805232929.GB2130@athene.usta.de>
[-- Attachment #1: Type: text/plain, Size: 953 bytes --]
On Sat, Aug 06, 2016 at 01:29:29AM +0200, Ingo Schwarze wrote:
> Hi Baptiste,
>
> Baptiste Daroussin FreeBSD wrote on Fri, Aug 05, 2016 at 09:40:57PM +0200:
>
> > I have been testing the very latest mandoc version from cvs (without sqlite)
> >
> > I notice 2 small issues on FreeBSD
> >
> > There is no endian.h on FreeBSD, so to get be32toh I need to include
> > <sys/endian.h> I bet it will be the same on at least Dragonfly and MacOS X
>
> And on Solaris, <sys/endian.h> does not exist either, so i committed
> what you see below.
I can confirm it works fine on freebsd thank you!
>
> > The second issue is dba.c needs (sys/)endian.h
>
> Fixed, too.
>
> Thanks for testing and reporting, and sorry for forgetting to
> mention you in the second commit message... I tested mostly on
> Solaris, which drove the FreeBSD case right out of my mind. :-(
no worry and thank you for prompt fixing!
Best regards,
Bapt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-08-05 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 19:40 Baptiste Daroussin
2016-08-05 23:29 ` Ingo Schwarze
2016-08-05 23:36 ` Baptiste Daroussin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805233639.grwxg4otpcoregeq@ivaldir.etoilebsd.net \
--to=bapt@freebsd.org \
--cc=tech@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).