From: Ingo Schwarze <schwarze@usta.de>
To: "Anthony J. Bentley" <anthony@anjbe.name>
Cc: tech@mdocml.bsd.lv
Subject: Re: Double quotes in man.cgi search output
Date: Mon, 12 Sep 2016 01:57:16 +0200 [thread overview]
Message-ID: <20160911235716.GB1204@athene.usta.de> (raw)
In-Reply-To: <35268.1472543039@CATHET.us>
Hi Anthony,
Anthony J. Bentley wrote on Tue, Aug 30, 2016 at 01:43:59AM -0600:
> html_putchar() escapes double quotes incorrectly: the entity should be
> ", not "e;.
>
> https://www.w3.org/TR/html5/syntax.html#named-character-references
>
> For example:
>
> http://man.openbsd.org/?query=Nd~%22&apropos=1
>
> In Firefox, each "e; is rendered as: "e;
> because Firefox believes what the author meant to write was "e;
OK schwarze@
Ingo
> Index: cgi.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/mandoc/cgi.c,v
> retrieving revision 1.77
> diff -u -p -r1.77 cgi.c
> --- cgi.c 18 Aug 2016 00:44:37 -0000 1.77
> +++ cgi.c 30 Aug 2016 07:34:28 -0000
> @@ -136,7 +136,7 @@ html_putchar(char c)
>
> switch (c) {
> case ('"'):
> - printf(""e;");
> + printf(""");
> break;
> case ('&'):
> printf("&");
--
To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv
prev parent reply other threads:[~2016-09-11 23:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 7:43 Anthony J. Bentley
2016-09-11 23:57 ` Ingo Schwarze [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160911235716.GB1204@athene.usta.de \
--to=schwarze@usta.de \
--cc=anthony@anjbe.name \
--cc=tech@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).