From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from scc-mailout-kit-02.scc.kit.edu (scc-mailout-kit-02.scc.kit.edu [129.13.231.82]) by fantadrom.bsd.lv (OpenSMTPD) with ESMTP id f4dfd3ad for ; Fri, 3 Feb 2017 13:07:06 -0500 (EST) Received: from asta-nat.asta.uni-karlsruhe.de ([172.22.63.82] helo=hekate.usta.de) by scc-mailout-kit-02.scc.kit.edu with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (envelope-from ) id 1cZiGF-00083m-0y; Fri, 03 Feb 2017 19:07:05 +0100 Received: from donnerwolke.usta.de ([172.24.96.3]) by hekate.usta.de with esmtp (Exim 4.77) (envelope-from ) id 1cZiGE-0007VP-La; Fri, 03 Feb 2017 19:07:02 +0100 Received: from athene.usta.de ([172.24.96.10]) by donnerwolke.usta.de with esmtp (Exim 4.84_2) (envelope-from ) id 1cZiGE-0004cR-AE; Fri, 03 Feb 2017 19:07:02 +0100 Received: from localhost (athene.usta.de [local]) by athene.usta.de (OpenSMTPD) with ESMTPA id 3083de88; Fri, 3 Feb 2017 19:07:02 +0100 (CET) Date: Fri, 3 Feb 2017 19:07:02 +0100 From: Ingo Schwarze To: Michael Stapelberg Cc: tech@mdocml.bsd.lv Subject: Re: [PATCH] Implement -u (UNIX socket batch processing) Message-ID: <20170203180702.GA40913@athene.usta.de> References: X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2 (2016-07-01) Hi Michael, Michael Stapelberg wrote on Sat, Jan 28, 2017 at 02:02:28PM +0100: > Attaching revision 2 which resets ->gzip in mparse_reset(). I > previously did not link against libz, so this issue escaped me. independent of your added code, this part of your patch is correct. You found a genuine bug here, so i committed that part of your patch, see below. Thanks, Ingo Log Message: ----------- If an application parses multiple files with mparse_readfd(3) but without using mparse_open(3) to open the files, and if one of the files includes a gzip'ed file with .so, then the gzip flag remains set and the next main file will be expected to be gzip'ed. Fix this by clearing the gzip flag in mparse_reset(3). Bug found and patch provided by Michael . Modified Files: -------------- mdocml: read.c Revision Data ------------- Index: read.c =================================================================== RCS file: /home/cvs/mdocml/mdocml/read.c,v retrieving revision 1.158 retrieving revision 1.159 diff -Lread.c -Lread.c -u -p -r1.158 -r1.159 --- read.c +++ read.c @@ -837,6 +837,7 @@ mparse_reset(struct mparse *curp) free(curp->sodest); curp->sodest = NULL; + curp->gzip = 0; } void -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv