Re: mandoc 1.14.3 segfault

[Ingo Schwarze <schwarze@usta.de>]

Hi Michael,

Michael Stapelberg wrote on Sat, Aug 12, 2017 at 12:27:32PM +0200:

> I'm running into a segfault with mandoc 1.14.3.

Sorry for the delay, i got distracted by xlocale support in our libc.

I just committed the patch below.

Given that

  .SS ""

is quite exotic (and nonsensical), i consider the issue minor
and not requiring an emergency release.

Thanks for both the report and the reminder!

Yours,
  Ingo


Log Message:
-----------
fix a NULL pointer access on deroff() failure;
could be triggered with '.SS ""';
reported by Michael <Stapelberg at debian>

Modified Files:
--------------
    mandoc:
        html.c

Revision Data
-------------
Index: html.c
===================================================================
RCS file: /home/cvs/mandoc/mandoc/html.c,v
retrieving revision 1.219
retrieving revision 1.220
diff -Lhtml.c -Lhtml.c -u -p -r1.219 -r1.220
--- html.c
+++ html.c
@@ -250,6 +250,8 @@ html_make_id(const struct roff_node *n)
 
 	buf = NULL;
 	deroff(&buf, n);
+	if (buf == NULL)
+		return NULL;
 
 	/* http://www.w3.org/TR/html5/dom.html#the-id-attribute */
 
--
 To unsubscribe send an email to tech+unsubscribe@mandoc.bsd.lv