From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from scc-mailout-kit-01.scc.kit.edu (scc-mailout-kit-01.scc.kit.edu [129.13.231.81]) by fantadrom.bsd.lv (OpenSMTPD) with ESMTP id f86ded3a for ; Wed, 6 Sep 2017 11:30:56 -0500 (EST) Received: from asta-nat.asta.uni-karlsruhe.de ([172.22.63.82] helo=hekate.usta.de) by scc-mailout-kit-01.scc.kit.edu with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (envelope-from ) id 1dpdE6-0004yh-W4; Wed, 06 Sep 2017 18:30:55 +0200 Received: from donnerwolke.usta.de ([172.24.96.3]) by hekate.usta.de with esmtp (Exim 4.77) (envelope-from ) id 1dpdE5-0006r9-0W; Wed, 06 Sep 2017 18:30:53 +0200 Received: from athene.usta.de ([172.24.96.10]) by donnerwolke.usta.de with esmtp (Exim 4.84_2) (envelope-from ) id 1dpdE4-0002rE-TZ; Wed, 06 Sep 2017 18:30:52 +0200 Received: from localhost (athene.usta.de [local]) by athene.usta.de (OpenSMTPD) with ESMTPA id 53d14469; Wed, 6 Sep 2017 18:30:52 +0200 (CEST) Date: Wed, 6 Sep 2017 18:30:52 +0200 From: Ingo Schwarze To: Michael Stapelberg Cc: tech@mdocml.bsd.lv Subject: Re: mandoc 1.14.3 segfault Message-ID: <20170906163052.GL4224@athene.usta.de> References: X-Mailinglist: mandoc-tech Reply-To: tech@mandoc.bsd.lv MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Hi Michael, Michael Stapelberg wrote on Sat, Aug 12, 2017 at 12:27:32PM +0200: > I'm running into a segfault with mandoc 1.14.3. Sorry for the delay, i got distracted by xlocale support in our libc. I just committed the patch below. Given that .SS "" is quite exotic (and nonsensical), i consider the issue minor and not requiring an emergency release. Thanks for both the report and the reminder! Yours, Ingo Log Message: ----------- fix a NULL pointer access on deroff() failure; could be triggered with '.SS ""'; reported by Michael Modified Files: -------------- mandoc: html.c Revision Data ------------- Index: html.c =================================================================== RCS file: /home/cvs/mandoc/mandoc/html.c,v retrieving revision 1.219 retrieving revision 1.220 diff -Lhtml.c -Lhtml.c -u -p -r1.219 -r1.220 --- html.c +++ html.c @@ -250,6 +250,8 @@ html_make_id(const struct roff_node *n) buf = NULL; deroff(&buf, n); + if (buf == NULL) + return NULL; /* http://www.w3.org/TR/html5/dom.html#the-id-attribute */ -- To unsubscribe send an email to tech+unsubscribe@mandoc.bsd.lv