tech@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: Ingo Schwarze <schwarze@usta.de>
To: Michael Forney <mforney@mforney.org>
Cc: tech@mandoc.bsd.lv
Subject: Re: [texi2mdoc] Documents without @node
Date: Tue, 13 Nov 2018 10:13:03 +0100	[thread overview]
Message-ID: <20181113091303.GC82487@athene.usta.de> (raw)
In-Reply-To: <CAGw6cBsOAYm5OO-EUgMyHk7X5D0P3W7NJkYz2RVH0b61j_cG2w@mail.gmail.com>

Hi Micheal,

Michael Forney wrote on Mon, Nov 12, 2018 at 05:23:14PM -0800:

> Actually, the output document is not completely blank, it contains
> quite a few `.Pp` lines. It looks like this is because the
> `fputs(".Pp\n", p->outfile)` in parseword is not guarded by a check of
> p->ign, which I believe is a bug.

I think you are right, so i committed your suggestion.
It also improves some valid documents; some had .Pp lines
even before the .Dd line.

Thanks for the report and analysis,
  Ingo


Log Message:
-----------
Add missing p->ign guard for paragraph breaks in parseword();
bug reported by Michael Forney <mforney at mforney dot org>.

Modified Files:
--------------
    texi2mdoc:
        util.c

Revision Data
-------------
Index: util.c
===================================================================
RCS file: /home/cvs/mdocml/texi2mdoc/util.c,v
retrieving revision 1.35
retrieving revision 1.36
diff -Lutil.c -Lutil.c -u -p -r1.35 -r1.36
--- util.c
+++ util.c
@@ -728,7 +728,8 @@ parseword(struct texi *p, size_t *pos, c
 	if (p->seenvs > 0 && 0 == p->literal && TEXILIST_TABLE != p->list) {
 		if (p->outcol > 0)
 			fputc('\n', p->outfile);
-		fputs(".Pp\n", p->outfile);
+		if (p->ign == 0)
+			fputs(".Pp\n", p->outfile);
 		p->outcol = 0;
 	}
 
--
 To unsubscribe send an email to tech+unsubscribe@mandoc.bsd.lv

  reply	other threads:[~2018-11-13  9:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13  1:23 Michael Forney
2018-11-13  9:13 ` Ingo Schwarze [this message]
2018-11-13 10:25 ` Ingo Schwarze
2018-11-13 19:07   ` Michael Forney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181113091303.GC82487@athene.usta.de \
    --to=schwarze@usta.de \
    --cc=mforney@mforney.org \
    --cc=tech@mandoc.bsd.lv \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).