From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from scc-mailout-kit-02.scc.kit.edu (scc-mailout-kit-02.scc.kit.edu [129.13.231.82]) by fantadrom.bsd.lv (OpenSMTPD) with ESMTP id 05409199 for ; Tue, 2 Apr 2019 12:20:40 -0500 (EST) Received: from asta-nat.asta.uni-karlsruhe.de ([172.22.63.82] helo=hekate.usta.de) by scc-mailout-kit-02.scc.kit.edu with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (envelope-from ) id 1hBN5S-0004oe-Cy; Tue, 02 Apr 2019 19:20:39 +0200 Received: from donnerwolke.usta.de ([172.24.96.3]) by hekate.usta.de with esmtp (Exim 4.77) (envelope-from ) id 1hBN5R-0005yr-RT; Tue, 02 Apr 2019 19:20:37 +0200 Received: from athene.usta.de ([172.24.96.10]) by donnerwolke.usta.de with esmtp (Exim 4.84_2) (envelope-from ) id 1hBN5R-00085v-M9; Tue, 02 Apr 2019 19:20:37 +0200 Received: from localhost (athene.usta.de [local]) by athene.usta.de (OpenSMTPD) with ESMTPA id 8405d17e; Tue, 2 Apr 2019 19:20:37 +0200 (CEST) Date: Tue, 2 Apr 2019 19:20:37 +0200 From: Ingo Schwarze To: Stephen Gregoratto Cc: tech@mandoc.bsd.lv Subject: Re: Parsing errors, output regressions with new XML parser Message-ID: <20190402172037.GG6369@athene.usta.de> References: <20190330001919.rrbc2xxrx47upalg@BlackBox> X-Mailinglist: mandoc-tech Reply-To: tech@mandoc.bsd.lv MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190330001919.rrbc2xxrx47upalg@BlackBox> User-Agent: Mutt/1.8.0 (2017-02-23) Hi Stephen, Stephen Gregoratto wrote on Sat, Mar 30, 2019 at 11:19:19AM +1100: > Another regression is that closing delimiters are put on separate > lines. This leads to SEE ALSO sections like this[2] being formatted > [2] https://gitlab.com/esr/doclifter/blob/master/doclifter.xml#L988 > like so: > > .Sh \&SEE ALSO > .Xr man 7 > , > .Xr mdoc 7 > , > .Xr ms 7 > , > .Xr me 7 > , > .Xr mm 7 > , > .Xr mwww 7 > , > .Xr troff 1 > \&. That was very easy to fix, see the commit below. Looks like i broke that in the big rev. 1.68. > I noticed in a previous email you've begun working on a regression > test suite of sorts. I could probably submit a couple examples of my > own so these errors don't crop up again. Sure, that would be welcome! Maybe i should make the suite publicly available soon, even though it is not portable yet. Yours, Ingo Log Message: ----------- handle trailing delimiters after /.Xr; bug reported by Stephen Gregoratto Modified Files: -------------- docbook2mdoc: docbook2mdoc.c Revision Data ------------- Index: docbook2mdoc.c =================================================================== RCS file: /home/cvs/mdocml/docbook2mdoc/docbook2mdoc.c,v retrieving revision 1.80 retrieving revision 1.81 diff -Ldocbook2mdoc.c -Ldocbook2mdoc.c -u -p -r1.80 -r1.81 --- docbook2mdoc.c +++ docbook2mdoc.c @@ -172,7 +172,6 @@ pnode_printciterefentry(struct format *p macro_addarg(p, "1", ARG_SPACE); else macro_addnode(p, manvol, ARG_SPACE | ARG_SINGLE); - macro_close(p); pnode_unlinksub(pn); } -- To unsubscribe send an email to tech+unsubscribe@mandoc.bsd.lv