tech@mandoc.bsd.lv
 help / color / Atom feed
From: Ingo Schwarze <schwarze@usta.de>
To: "Anthony J. Bentley" <anthony@anjbe.name>
Cc: tech@mandoc.bsd.lv
Subject: Re: Qq should print straight quotes in -Thtml
Date: Mon, 9 Dec 2019 16:05:27 +0100
Message-ID: <20191209150527.GJ42292@athene.usta.de> (raw)
In-Reply-To: <47670-1575889959.675959@0_Kr.Y4xw.xcq1>

Hi Anthony,

Anthony J. Bentley wrote on Mon, Dec 09, 2019 at 04:12:39AM -0700:

> According to mdoc(7):
> 
>      Qq, Qo, Qc       enclose in typewriter double quotes: "text"
> 
> Indeed, mdoc_term.c intentionally uses straight quotes:
> 
>         case MDOC_Qo:
>         case MDOC_Qq:
>                 term_word(p, "\"");
>                 break;
> 
> mdoc_html.c uses curly quotes, but it should match mdoc_term.c.

Thanks for catching this bug!

> ok?

Yes, please commit.
  Ingo


> Index: mdoc_html.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/mandoc/mdoc_html.c,v
> retrieving revision 1.206
> diff -u -p -r1.206 mdoc_html.c
> --- mdoc_html.c	15 Sep 2019 00:08:46 -0000	1.206
> +++ mdoc_html.c	8 Dec 2019 19:47:24 -0000
> @@ -1717,9 +1717,11 @@ mdoc_quote_pre(MDOC_ARGS)
>  		break;
>  	case MDOC_Do:
>  	case MDOC_Dq:
> +		print_text(h, "\\(lq");
> +		break;
>  	case MDOC_Qo:
>  	case MDOC_Qq:
> -		print_text(h, "\\(lq");
> +		print_text(h, "\"");
>  		break;
>  	case MDOC_Po:
>  	case MDOC_Pq:
> @@ -1775,11 +1777,13 @@ mdoc_quote_post(MDOC_ARGS)
>  		else
>  			print_text(h, n->norm->Es->child->next->string);
>  		break;
> -	case MDOC_Qo:
> -	case MDOC_Qq:
>  	case MDOC_Do:
>  	case MDOC_Dq:
>  		print_text(h, "\\(rq");
> +		break;
> +	case MDOC_Qo:
> +	case MDOC_Qq:
> +		print_text(h, "\"");
>  		break;
>  	case MDOC_Po:
>  	case MDOC_Pq:
--
 To unsubscribe send an email to tech+unsubscribe@mandoc.bsd.lv

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 11:12 Anthony J. Bentley
2019-12-09 15:05 ` Ingo Schwarze [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191209150527.GJ42292@athene.usta.de \
    --to=schwarze@usta.de \
    --cc=anthony@anjbe.name \
    --cc=tech@mandoc.bsd.lv \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

tech@mandoc.bsd.lv

Archives are clonable: git clone --mirror http://inbox.vuxu.org/mandoc-tech

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.mandoc.tech


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git