tech@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: Ingo Schwarze <schwarze@usta.de>
To: sternenseemann@systemli.org
Cc: tech@mandoc.bsd.lv
Subject: Re: makewhatis: segfault in dbadd when using -a
Date: Mon, 6 Sep 2021 16:50:47 +0200	[thread overview]
Message-ID: <20210906145047.GC83680@athene.usta.de> (raw)
In-Reply-To: <20210819171150.GD56790@athene.usta.de>

Hi Lukas,

Ingo Schwarze wrote on Thu, Aug 19, 2021 at 07:11:50PM +0200:

> Uh oh.  So there *is* a real-world use case for symlinks to
> directories.
[...]
> Anyway, if systems use that, considering whether it can be supported
> with resonable effort makes sense.  No guarantee, of course.
> I'll think about it for a bit.

So, an acceptable way to support this probably exists, using the
FTS_FOLLOW option of the function fts_set(3).  That isn't completely
trivial in this code which is already somewhat convoluted, but it
should not be excessively complicated either.  Then again, there
is a slight risk of breaking stuff while implementing it, and maybe
an even bigger risk that FTS_FOLLOW may not be completely portable -
i don't really know yet.

Besides, i need to limit the difficulty of changes i'm doing right
now or i will never get the next release out of the door.  So i
decided to postpone this particular feature until after release,
see the commit below.

Yours,
  Ingo


Log Message:
-----------
TODO: let makewhatis(8) follow symbolic links to dirs

Modified Files:
--------------
    mandoc:
        TODO

Revision Data
-------------
Index: TODO
===================================================================
RCS file: /home/cvs/mandoc/mandoc/TODO,v
retrieving revision 1.316
retrieving revision 1.317
diff -LTODO -LTODO -u -p -r1.316 -r1.317
--- TODO
+++ TODO
@@ -286,6 +286,11 @@ are mere guesses, and some may be wrong.
 
 --- missing misc features ----------------------------------------------
 
+- let makewhatis(8) follow symbolic links to dirs below READ_ALLOWED_PATH
+  this may be feasible using fts_set(FTS_FOLLOW)
+  mail to sternenseemann 19 Aug 2021 19:11:50 +0200
+  loc *  exist **  algo **  size *  imp **
+
 - -T man does not handle eqn(7) and tbl(7)
   Stephen Gregoratto 16 Feb 2020 01:28:07 +1100
   also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901636
--
 To unsubscribe send an email to tech+unsubscribe@mandoc.bsd.lv


  reply	other threads:[~2021-09-06 14:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06 23:53 sternenseemann
2021-08-11 15:09 ` Ingo Schwarze
2021-08-18 22:02   ` sternenseemann
2021-08-19 17:11     ` Ingo Schwarze
2021-09-06 14:50       ` Ingo Schwarze [this message]
2021-09-06 15:52         ` sternenseemann
2021-09-06 17:12           ` Ingo Schwarze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210906145047.GC83680@athene.usta.de \
    --to=schwarze@usta.de \
    --cc=sternenseemann@systemli.org \
    --cc=tech@mandoc.bsd.lv \
    --subject='Re: makewhatis: segfault in dbadd when using -a' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).