tech@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: Anna Vyalkova <cyber@sysrq.in>
To: tech@mandoc.bsd.lv
Subject: [PATCH] cgi.c: label query and manpath
Date: Wed,  6 Jul 2022 20:52:09 +0500	[thread overview]
Message-ID: <20220706155209.2475-1-cyber@sysrq.in> (raw)

---

Is visible label OK? Or should it be hidden?

 cgi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/cgi.c b/cgi.c
index a6cacd02..75e91ba1 100644
--- a/cgi.c
+++ b/cgi.c
@@ -444,7 +444,8 @@ resp_searchform(const struct req *req, enum focus focus)
 
 	/* Write query input box. */
 
-	printf("    <input type=\"search\" name=\"query\" value=\"");
+	puts("    <label for=\"query\">Search query</label>");
+	printf("    <input type=\"search\" name=\"query\" id=\"query\" value=\"");
 	if (req->q.query != NULL)
 		html_print(req->q.query);
 	printf( "\" size=\"40\"");
@@ -491,7 +492,7 @@ resp_searchform(const struct req *req, enum focus focus)
 	/* Write manpath selector. */
 
 	if (req->psz > 1) {
-		puts("    <select name=\"manpath\">");
+		puts("    <select name=\"manpath\" aria-label=\"manual path\">");
 		for (i = 0; i < (int)req->psz; i++) {
 			printf("      <option");
 			if (strcmp(req->q.manpath, req->p[i]) == 0)
-- 
2.35.1

--
 To unsubscribe send an email to tech+unsubscribe@mandoc.bsd.lv


             reply	other threads:[~2022-07-06 15:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06 15:52 Anna Vyalkova [this message]
2022-07-06 17:40 ` Ingo Schwarze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220706155209.2475-1-cyber@sysrq.in \
    --to=cyber@sysrq.in \
    --cc=tech@mandoc.bsd.lv \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).