From: Kristaps Dzonsons <kristaps@bsd.lv>
To: "tech@mdocml.bsd.lv" <tech@mdocml.bsd.lv>
Subject: Lint, vbl, and p->offset.
Date: Mon, 24 May 2010 23:41:42 +0200 [thread overview]
Message-ID: <4BFAF296.9060104@bsd.lv> (raw)
Hello!
`make lint LINTFLAGS="-cefuhx"' shows an interesting
term.c:164: warning: converted from 'int' to 'unsigned long'
term.c:164: vbl = p->flags & TERMP_NOLPAD ? 0 : p->offset;
term.c:171: warning: converted from 'int' to 'unsigned long'
term.c:171: vis = vend = i = 0;
I'm pretty sure that p->offset can be negative when it arrives (at least
it was once upon a time). Can this be case and LINTED or does it need
fixin'? If offset is no longer negative ever, it should be made into a
size_t.
Thanks,
Kristaps
--
To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv
reply other threads:[~2010-05-24 21:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFAF296.9060104@bsd.lv \
--to=kristaps@bsd.lv \
--cc=tech@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).