From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-1.sys.kth.se (smtp-1.sys.kth.se [130.237.32.175]) by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id o4OLe4ES027957 for ; Mon, 24 May 2010 15:40:05 -0600 (MDT) Received: from localhost (localhost [127.0.0.1]) by smtp-1.sys.kth.se (Postfix) with ESMTP id 9CB86155AEA for ; Mon, 24 May 2010 23:39:59 +0200 (CEST) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-1.sys.kth.se ([127.0.0.1]) by localhost (smtp-1.sys.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NchJ4rAvt7JL for ; Mon, 24 May 2010 23:39:58 +0200 (CEST) X-KTH-Auth: kristaps [85.8.61.100] X-KTH-mail-from: kristaps@bsd.lv X-KTH-rcpt-to: tech@mdocml.bsd.lv Received: from lappy.bsd.lv (h85-8-61-100.dynamic.se.alltele.net [85.8.61.100]) by smtp-1.sys.kth.se (Postfix) with ESMTP id 9286B1558C5 for ; Mon, 24 May 2010 23:39:58 +0200 (CEST) Message-ID: <4BFAF296.9060104@bsd.lv> Date: Mon, 24 May 2010 23:41:42 +0200 From: Kristaps Dzonsons User-Agent: Thunderbird 2.0.0.16 (X11/20080812) X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 To: "tech@mdocml.bsd.lv" Subject: Lint, vbl, and p->offset. Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello! `make lint LINTFLAGS="-cefuhx"' shows an interesting term.c:164: warning: converted from 'int' to 'unsigned long' term.c:164: vbl = p->flags & TERMP_NOLPAD ? 0 : p->offset; term.c:171: warning: converted from 'int' to 'unsigned long' term.c:171: vis = vend = i = 0; I'm pretty sure that p->offset can be negative when it arrives (at least it was once upon a time). Can this be case and LINTED or does it need fixin'? If offset is no longer negative ever, it should be made into a size_t. Thanks, Kristaps -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv