Re: PATCH: break the line at an existing hyphen

[Kristaps Dzonsons <kristaps@bsd.lv>]

> here is the final patch to get bsd.lv in sync with OpenBSD.
> 
> I know Kristaps backed something like this out once already,
> i guess it got in the way back then, before the term_flushln() cleanup.
> 
> But now, after the cleanup, this has become really easy,
> it is just three simple steps:
> 
>  1. While scanning forward for the first time, remember
>     the last hyphen fitting on the line.
>  2. When deciding whether to break the line at once,
>     don't do it when there is a useable hyphen.
>  3. Finally, while scanning forward for the second time,
>     i.e. in the output loop, break at the hyphen, if required.
> 
> Of course, it is not very difficult to make this a bit fancier
> and avoid some breaks that make little sense - but this is what
> OpenBSD has now, and it helps us to get in sync.
> 
> I would rather put this in than back it out, if only because
> it makes automatic comparisons a lot easier...
> 
> This final patch is also here:
>   /usr/vhosts/mdocml.bsd.lv/patch/schwarze/09.break-at-hyphen.patch

I've checked in a modified version of this that only breaks at free-form
line hyphens along with a regression test.  It touches term.c (your
exact patch, Ingo, except with ASCII_HYPH instead of the hyphen), html.c
(to print a hyphen (NOT a soft-break, see note)), mdoc.c (sitting in
Ingo's white-space loop), and mandoc.c (for the actual function of
choosing).

The same happens in -man, but I'll wait til Ingo applies his white-space
code to -man for this to be implemented.

Kristaps
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv