From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-2.sys.kth.se (smtp-2.sys.kth.se [130.237.32.160]) by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id o5DJX5NF032441 for ; Sun, 13 Jun 2010 15:33:06 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by smtp-2.sys.kth.se (Postfix) with ESMTP id B730B14DC80 for ; Sun, 13 Jun 2010 21:32:59 +0200 (CEST) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-2.sys.kth.se ([127.0.0.1]) by localhost (smtp-2.sys.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qWad7v+RxTc3 for ; Sun, 13 Jun 2010 21:32:58 +0200 (CEST) X-KTH-Auth: kristaps [85.8.61.94] X-KTH-mail-from: kristaps@bsd.lv X-KTH-rcpt-to: tech@mdocml.bsd.lv Received: from lappy.bsd.lv (h85-8-61-94.dynamic.se.alltele.net [85.8.61.94]) by smtp-2.sys.kth.se (Postfix) with ESMTP id EC40C14DC77 for ; Sun, 13 Jun 2010 21:32:56 +0200 (CEST) Message-ID: <4C153267.5080904@bsd.lv> Date: Sun, 13 Jun 2010 21:32:55 +0200 From: Kristaps Dzonsons User-Agent: Thunderbird 2.0.0.16 (X11/20080812) X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 To: tech@mdocml.bsd.lv Subject: Re: Reducing uname footer string on FreeBSD References: <20100609163447.GA39829@acme.spoerlein.net> <20100612171844.GE6086@iris.usta.de> In-Reply-To: <20100612171844.GE6086@iris.usta.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit >> The attached patch clamps the string after the dash, iff uname reports >> we are running on FreeBSD. I don't think such special casing should be >> applied in the general source tree, but wanted to put it up for >> discussion anyway. > > Actually, i wouldn't even object to this particular patch going in > in case that's easier for you. After all, > > - post_os() is typically called once per input file; > - this is the central place where OS names are handled, > so having differences here is not that surprising; > - your patch is not expensive: linear in the length > of the string "FreeBSD" on FreeBSD, one return-at-once > function call everywhere else. > > So, even if all the four major free BSD implementations would > need something like this in post_os(), it would still seem > reasonable to me. Ulrich and Ingo, I have no objection to this being merged so long as you (Ulrich) can guarantee that this behaviour is general, i.e., that this will not cause badness in any sort of FreeBSD configuration. Thanks, Kristaps -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv