Re: [PATCH] rudimentary .ds support

[Kristaps Dzonsons <kristaps@bsd.lv>]

> a couple of manuals use the roff .ds instruction and the roff \s
> escape function.  Here is a rudimentary implementation, just to
> get the contents of the manuals right for now.
> 
> I'm aware of the following deficiencies:
> 
>  * mandoc is just taking the string manually, while groff
>    is still interpreting it in some way.
>    For strings without special characters, this makes no difference.
>  * Quoted string parsing in roff_ds() is not correct,
>    but a quick hack.
>  * Using a singly linked list for the string table is fine for
>    small numbers of user-defined strings, which is currently our
>    typical use case.  In the long run, we probably want some
>    hash table or tree structure.
>  * String inclusion comes too late in term.c, function res().
>    This will use the last string defined in the file, not the one
>    defined at the right point of the file.
>  * I deliberately use the user user-defined strings only when no
>    predefined strings are available, while groff allows to override
>    predefined strings.  As long as this feature is still rather
>    sloppily implemented, this limits the potential breakage.
>  * HTML rendering is missing (but trivial).
> 
> These aspects can be improved later.
> For now, it is important to move on as quickly as possible
> and fix as many bugs relevant for the system build as possible.
> Not much time is left until the 4.8 release lock.
> 
> For examples of manuals fixed by this patch, see terminfo(3),
> in particular the .Xr to terminfo(5) below SEE ALSO, and
> mdoc.samples(7), using the included patch.
> 
> OK to commit?
> (Of course, i would then remove the debugging print statements
> in roff_freestr.)

Ingo,

I see the utility of this, but would like the functions accessed through 
regs.h, either within struct regset itself or as its own structure with 
setters and getters.  This is just a mechanical change, of course.  In 
general, roff.h should not propogate into libmdoc or libman; they are 
distinct namespaces.  regs.h is poorly-named, in this regard, but that 
can be switched later.

Other than that, it looks fine.  Needs bits in html.c (I can do this, if 
you don't want to muck around in there) and roff.3 (including the 
current short-comings).

Thanks,

Kristaps
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv