Re: Non-ASCII check fails in main.c on OpenBSD

[Kristaps Dzonsons <kristaps@bsd.lv>]

> i just noticed that on OpenBSD, the change main.c bsd.lv-rev. 1.99
> pathetically fails.  Non-ASCII characters are just passed through.
> 
> Now maybe that's a bug in OpenBSD isgraph(3), maybe it is not and
> isgraph(3) behaves like it does on purpose - actually, i don't really
> care that much either way, and i doubt that it will be easy to get
> OpenBSD isgraph(3) changed.
> 
> For maximum portability, i think when we put a comment
> 
>   /* 
>    * Warn about bogus characters.  If you're using
>    * non-ASCII encoding, you're screwing your
>    * readers.  Since I'd rather this not happen,
>    * I'll be helpful and drop these characters so
>    * we don't display gibberish.  Note to manual
>    * writers: use special characters.
>    */
> 
> which i fully agree with, we should also be explicit in the code,
> or we risk that on some systems our code behaves in another way than
> the comments make you think and than we intend, which is always bad.
> 
> So, as we want to drop non-ASCII, lets explicitely use isascii(3).
> 
> OK to commit to bsd.lv?
> 
> Of course, this will not be merged to OpenBSD until after unlock.

Ingo, good catch!  But yes, I tested this code on a GNU/Linux machine, 
never thinking that the behaviour would be different on OpenBSD.

Ok kristaps.
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv