From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-2.sys.kth.se (smtp-2.sys.kth.se [130.237.32.160]) by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id o8Q9DFKB000724 for ; Sun, 26 Sep 2010 05:13:16 -0400 (EDT) Received: from mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) by smtp-2.sys.kth.se (Postfix) with ESMTP id 8191514F2D3 for ; Sun, 26 Sep 2010 11:13:09 +0200 (CEST) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-2.sys.kth.se ([130.237.32.160]) by mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) (amavisd-new, port 10024) with LMTP id 9kVHMkNhEGOV for ; Sun, 26 Sep 2010 11:13:07 +0200 (CEST) X-KTH-Auth: kristaps [85.8.60.37] X-KTH-mail-from: kristaps@bsd.lv X-KTH-rcpt-to: tech@mdocml.bsd.lv Received: from lappy.cust.alltele.se (h85-8-60-37.dynamic.se.alltele.net [85.8.60.37]) by smtp-2.sys.kth.se (Postfix) with ESMTP id 7477014DCD0 for ; Sun, 26 Sep 2010 11:13:06 +0200 (CEST) Message-ID: <4C9F0EA1.3080302@bsd.lv> Date: Sun, 26 Sep 2010 11:13:05 +0200 From: Kristaps Dzonsons User-Agent: Thunderbird 2.0.0.23 (X11/20100318) X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 To: tech@mdocml.bsd.lv Subject: Re: tweak message "scope open on exit" References: <20100923225445.GG11894@iris.usta.de> In-Reply-To: <20100923225445.GG11894@iris.usta.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > in mdoc(7), if an explicit scope is still open at the end of an input > file, that's FATAL. I really don't see why, it's trivial to just > close out the block and proceed to rendering the file. > > On the other hand, in man(7), if an explicit scope is still open at > the end of an input file, that's merely a WARNING. I regard that > as dangerous, because an unclosed block probably means that either: > > - some input text is missing, resulting in incomplete output > - or closure of a block is missing, probably resulting in > garbled document structure from that point onwards. > > As i see it, that's a typical case of a non-fatal ERROR: > We can render, but probably infomation is missing or the > structure is seriously mangled. > > Besides, why not use the same error type for mdoc(7) and man(7)? > > And finally, since we do know that the error is non-fatal, > there is no need to check the return value of the msg function. Ingo, this looks good. At first I dithered for a while about returning 0 to mdoc_endparse(), but because the error is non-fatal, your reasoning is sound and I agree. Can you fix up the WARNING->ERROR logic in libman, too? Thanks, Kristaps -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv