From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-2.sys.kth.se (smtp-2.sys.kth.se [130.237.32.160]) by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id oB2ApYkW013021 for ; Thu, 2 Dec 2010 05:51:36 -0500 (EST) Received: from mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) by smtp-2.sys.kth.se (Postfix) with ESMTP id D4E6114F354 for ; Thu, 2 Dec 2010 11:51:28 +0100 (CET) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-2.sys.kth.se ([130.237.32.160]) by mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) (amavisd-new, port 10024) with LMTP id 5C3uqIVkidM6 for ; Thu, 2 Dec 2010 11:51:26 +0100 (CET) X-KTH-Auth: kristaps [85.8.60.142] X-KTH-mail-from: kristaps@bsd.lv X-KTH-rcpt-to: tech@mdocml.bsd.lv Received: from h85-8-60-142.dynamic.se.alltele.net (h85-8-60-142.dynamic.se.alltele.net [85.8.60.142]) by smtp-2.sys.kth.se (Postfix) with ESMTP id E9B1314F34E for ; Thu, 2 Dec 2010 11:51:24 +0100 (CET) Message-ID: <4CF77A2B.6020702@bsd.lv> Date: Thu, 02 Dec 2010 11:51:23 +0100 From: Kristaps Dzonsons User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 To: tech@mdocml.bsd.lv Subject: Re: exit_status persistence (now: roff.c question). References: <4CF678F0.6020304@bsd.lv> <20101201212834.GA22990@iris.usta.de> In-Reply-To: <20101201212834.GA22990@iris.usta.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit >> Ingo, I flushed out some peculiar behaviour in the new main.c. >> >> If a FATAL parse error occurs (e.g., rxdebug.1) when multiple files >> are passed on the command-line, subsequent files are parsed but not >> outputted. This occurs due to main.c:484. I don't want to monkey >> with exit_status---can you verify that exit_status may somehow be >> saved or reset between parses so that passing multiple files doesn't >> cause truncated output? > > Looking at the code, i'd say you are right, this looks like a blatant > design error and needs to be fixed. > I'll probably split exit_status into two variables: > First, file_status will be initialized to MANDOCERR_OK for each > file, and that's the one mmsg will write to. > Then, at the end of each file, the contents must be moved to > exit_status, in case it's more severe than what is already there. > > I'll cook up a patch after completing the bsd.lv -> OpenBSD merges. > Merge, then write code is usually better than the other way round. :) Another question---I'm about to check in roff.c as fully in sync after running some more tests---I notice that `de1' has been removed from the switch statement at roff.c:549. I understand this is because `de1' is renamed at roff.c:636. If this is the case, can you document this process a bit more? There's also an infinite loop somewhere in these new roff.c changes that's causing the NetBSD manuals to blow up... -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv