Re: [PATCH] uniform parsing of names in libroff

[Kristaps Dzonsons <kristaps@bsd.lv>]

On 10/01/2011 23:52, Ingo Schwarze wrote:
> Hi,
>
> i just started to implement .rm (remove macro) in libroff,
> then realized that i would be introducing the third place
> where names (that is, to be precise, roff macro and string names)
> get parsed.
>
> The following patch moves this parsing into its own function,
> to be soon reused by roff_rm().
>
> I put that function roff_getname() in libroff (and not in
> libmandoc) because i do not expect any macro package to deal
> with that kind of low-level stuff.
>
> The interface is similar to mandoc_getarg(), but much simpler,
> because quotes count as normal characters in this context,
> space characters cannot be escaped, and backslashes are only
> allowed in pairs.  Yes, parsing of names has its own rules,
> and they are quite different from the rules for parsing of
> arguments.  See, this is roff, right?
>
> As a bonus:
>   - Both roff_ds and roff_nr become much shorter.
>   - We get an ERROR when there are escapes in a name.
>
> OK?

Ingo, I'm fine with this.

Let me know when your changes into libroff are finished---I want to hash 
setstr() stuff, as there are a lot of pod2man and man pages with lots of 
requests, and we can probably make a measurably impact on performance.

Thanks,

Kristaps
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv