From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-1.sys.kth.se (smtp-1.sys.kth.se [130.237.32.175]) by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id p0MMSKNn006271 for ; Sat, 22 Jan 2011 17:28:21 -0500 (EST) Received: from mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) by smtp-1.sys.kth.se (Postfix) with ESMTP id C2BC2155AF1; Sat, 22 Jan 2011 23:28:14 +0100 (CET) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-1.sys.kth.se ([130.237.32.175]) by mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) (amavisd-new, port 10024) with LMTP id LyFWVpa-lNHE; Sat, 22 Jan 2011 23:28:13 +0100 (CET) X-KTH-Auth: kristaps [85.8.60.80] X-KTH-mail-from: kristaps@bsd.lv Received: from h85-8-60-80.dynamic.se.alltele.net (h85-8-60-80.dynamic.se.alltele.net [85.8.60.80]) by smtp-1.sys.kth.se (Postfix) with ESMTP id E2BF51558AE; Sat, 22 Jan 2011 23:28:12 +0100 (CET) Message-ID: <4D3B59FB.2080301@bsd.lv> Date: Sat, 22 Jan 2011 23:28:11 +0100 From: Kristaps Dzonsons User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 To: tech@mdocml.bsd.lv CC: Ingo Schwarze Subject: Re: line termination in manuals References: <20110122195656.GE12520@iris.usta.de> <20110122200516.GA26592@britannica.bec.de> <20110122212814.GH12520@iris.usta.de> <20110122213510.GA29547@britannica.bec.de> <20110122221836.GJ12520@iris.usta.de> In-Reply-To: <20110122221836.GJ12520@iris.usta.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit >> At least add a comment that this falls through to the next statement >> for handling. Otherwise it looks fine. > > Gah, writing comments is good. > It makes you think again about the code, > so you find bugs. > > When the last character in blk.buf is '\r' (without a newline > at the end of the file), my first attempt would have overrun > the buffer by one byte. > > Thus, i'm committing the following shortly. Has somebody checked whether groff accepts these in the same way? Thanks, Kristaps -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv