From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-2.sys.kth.se (smtp-2.sys.kth.se [130.237.32.160]) by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id p16LkDrQ019527 for ; Sun, 6 Feb 2011 16:46:13 -0500 (EST) Received: from mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) by smtp-2.sys.kth.se (Postfix) with ESMTP id A6AD114DC75 for ; Sun, 6 Feb 2011 22:46:07 +0100 (CET) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-2.sys.kth.se ([130.237.32.160]) by mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) (amavisd-new, port 10024) with LMTP id l6R8N51qpiXs for ; Sun, 6 Feb 2011 22:46:06 +0100 (CET) X-KTH-Auth: kristaps [85.8.61.107] X-KTH-mail-from: kristaps@bsd.lv X-KTH-rcpt-to: tech@mdocml.bsd.lv Received: from h85-8-61-107.dynamic.se.alltele.net (h85-8-61-107.dynamic.se.alltele.net [85.8.61.107]) by smtp-2.sys.kth.se (Postfix) with ESMTP id 0063714DC4B for ; Sun, 6 Feb 2011 22:46:05 +0100 (CET) Message-ID: <4D4F169C.2030800@bsd.lv> Date: Sun, 06 Feb 2011 22:46:04 +0100 From: Kristaps Dzonsons User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 To: tech@mdocml.bsd.lv Subject: Re: Bugs and regressions in .Bk References: <201101251620.p0PGKPeH004751@krisdoz.my.domain> <20110206203930.GH28747@iris.usta.de> In-Reply-To: <20110206203930.GH28747@iris.usta.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 06/02/2011 21:39, Ingo Schwarze wrote: > Hi Kristaps, > >> Log Message: >> ----------- >> Arguments to `Bsx' and friends are separated by a non-breaking space. >> This removes a TODO raised by schwarze@. > > While trying to merge this patch, i ran into a regression: > When called inside .Bk or in the SYNOPSIS, this patch ends > keep mode. > > Trying to fix that (meanwhile, i have a working fix, so don't > waste your time searching for it), i ran into another .Bk bug: > For text generated in the pre-handler, setting up keep state > comes too late to take effect. > > So, my plan is to > > 1) Get the following patch in, fixing the latter bug - OK? > The code is unchanged, it is just moved around. > > 2) Once that's in, merge your patch to OpenBSD, together > with my fix for the regression. > > 3) Finally, merge back my regression fix to bsd.lv. Ingo, That's fine by me. I haven't closely examined the behaviour, but it looks reasonable. Please add in the necessary comments in the code as to why the order is important, though... Thanks! Kristaps -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv