Re: Logic error in mandoc.c time2a()

[Kristaps Dzonsons <kristaps@bsd.lv>]

> +	p = buf = mandoc_malloc(10 + 4 + 4 + 1);
>
> -	if (0 == (nsz = strftime(p, rsz, "%B ",&tm)))
> -		return(NULL);
> -
> -	p += (int)nsz;
> -	rsz -= nsz;
> -
> -	if (-1 == (isz = snprintf(p, rsz, "%d, ", tm.tm_mday)))
> -		return(NULL);
> +	if (0 == (ssz = strftime(p, 10 + 1, "%B ",&tm)))
> +		goto fail;
> +	p += (int)ssz;
>
> +	if (-1 == (isz = snprintf(p, 4 + 1, "%d, ", tm.tm_mday)))
> +		goto fail;
>   	p += isz;
> -	rsz -= isz;
>
> -	return(strftime(p, rsz, "%Y",&tm) ? buf : NULL);
> +	if (0 == strftime(p, 4 + 1, "%Y",&tm))
> +		goto fail;
> +	return(buf);
> +
> +fail:
> +	free(buf);
> +	return(NULL);

Ingo,

I'm fine with the motion of this diff, but please thoroughly document 
the numbers in this before you commit.  Yes, they're clear upon 
inspection, but I want more in there than 10 + 4 + 4 + 1... But given 
this, ok kristaps.

Thanks!

Kristaps
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv