1.11.7 regression: infinite loop in roff_res()

1.11.7 regression: infinite loop in roff_res()

[Ingo Schwarze]

CVSROOT:	/cvs
Module name:	src
Changes by:	schwarze@cvs.openbsd.org	2011/09/18 17:26:18

Modified files:
	usr.bin/mandoc : roff.c 

Log message:
Fix another regression introduced in 1.11.7:
If a string is defined in terms of itself, the REPARSE_LIMIT in read.c
used to break the cycle.  This no longer works since all the work
is now done in the function roff_res(), looping indefinitely.

Make this loop finite by arbitrarily limiting the number of times one
string may be expanded; when that limit is reached, leave the remaining
string references unexpanded.

This changes behaviour compared to 1.11.5, where the whole line would
have been dropped.  The new behaviour is better because it loses less
information.  We don't want to imitate groff-1.20.1 behaviour anyway
because groff aborts parsing of the whole file.


OK to commit to bsd.lv as well?
  Ingo


Index: roff.c
===================================================================
RCS file: /cvs/src/usr.bin/mandoc/roff.c,v
retrieving revision 1.42
diff -u -p -r1.42 roff.c
--- roff.c	18 Sep 2011 15:54:48 -0000	1.42
+++ roff.c	18 Sep 2011 23:01:05 -0000
@@ -27,6 +27,9 @@
 /* Maximum number of nested if-else conditionals. */
 #define	RSTACK_MAX	128
 
+/* Maximum number of string expansions per line, to break infinite loops. */
+#define	EXPAND_LIMIT	1000
+
 enum	rofft {
 	ROFF_ad,
 	ROFF_am,
@@ -433,10 +436,12 @@ roff_res(struct roff *r, char **bufp, si
 	const char	*stnam;	/* start of the name, after "[(*" */
 	const char	*cp;	/* end of the name, e.g. before ']' */
 	const char	*res;	/* the string to be substituted */
-	int		 i, maxl;
+	int		 i, maxl, expand_count;
 	size_t		 nsz;
 	char		*n;
 
+	expand_count = 0;
+
 again:
 	cp = *bufp + pos;
 	while (NULL != (cp = strchr(cp, '\\'))) {
@@ -531,7 +536,13 @@ again:
 
 		*bufp = n;
 		*szp = nsz;
-		goto again;
+
+		if (EXPAND_LIMIT >= ++expand_count)
+			goto again;
+
+		/* Just leave the string unexpanded. */
+		mandoc_msg(MANDOCERR_ROFFLOOP, r->parse, ln, pos, NULL);
+		return;
 	}
 }
 
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv

Re: 1.11.7 regression: infinite loop in roff_res()

[Kristaps Dzonsons]

Ingo,

Good catch---I just saw this on the source-commits mailing list.  Please 
check this in!

Thanks,

Kristaps
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv