From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-1.sys.kth.se (smtp-1.sys.kth.se [130.237.32.175]) by krisdoz.my.domain (8.14.3/8.14.3) with ESMTP id p8KMXUkF029215 for ; Tue, 20 Sep 2011 18:33:31 -0400 (EDT) Received: from mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) by smtp-1.sys.kth.se (Postfix) with ESMTP id D2E4A15588C; Wed, 21 Sep 2011 00:33:24 +0200 (CEST) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-1.sys.kth.se ([130.237.32.175]) by mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) (amavisd-new, port 10024) with LMTP id ZtuvCMvasU0J; Wed, 21 Sep 2011 00:33:22 +0200 (CEST) X-KTH-Auth: kristaps [83.250.3.9] X-KTH-mail-from: kristaps@bsd.lv Received: from macky.local (c83-250-3-9.bredband.comhem.se [83.250.3.9]) by smtp-1.sys.kth.se (Postfix) with ESMTP id 1FCE81557D3; Wed, 21 Sep 2011 00:33:20 +0200 (CEST) Message-ID: <4E7914B0.7010101@bsd.lv> Date: Wed, 21 Sep 2011 00:33:20 +0200 From: Kristaps Dzonsons User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.22) Gecko/20110902 Thunderbird/3.1.14 X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 To: tech@mdocml.bsd.lv CC: Ingo Schwarze , Yuri Pankov Subject: Re: tbl issues with 1.11.1 References: <20110414014526.GB1280@darklight.org.ru> <20110416213413.GI13629@iris.usta.de> <20110426201050.GA5448@britannica.bec.de> <20110512220226.GA23153@britannica.bec.de> <4DCD9CA4.2060708@bsd.lv> <20110514041228.GA30797@iris.usta.de> <20110920173247.GF13269@iris.usta.de> In-Reply-To: <20110920173247.GF13269@iris.usta.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 20/09/2011 19:32, Ingo Schwarze wrote: > Hi, > > Ingo Schwarze wrote on Sat, May 14, 2011 at 06:12:28AM +0200: > >> Getting this right in both cases - with and without vertical rulers - >> requires rather large changes. The logic, as far as i understand it >> so far, goes like this: >> >> - box produces "|" >> - no spacing at this point >> - first cell, width is max(lengths) >> - one space >> - vertical ruler, if none, another space >> - another space, unless there was a double ruler (!!) >> - second cell >> - and so on. >> >> That is vastly different from what we have now, both regarding the >> width calculations - which apparently must not include padding - and >> regarding the output itself. >> >> The work-in-progress patch below comes closer. However, it still >> has at least two deficiencies, so it is not ready for commit: >> - There still is a bogus space after double rulers, see (!!). >> - The handling of explicit spacing options got sweeped away >> by the reorg i was forced to do. Probably, i need to put >> it back in at the right places. It was in the calc routine >> but probably belongs in the output routines themselves. > > I now have an updated diff that i consider ripe for commit, > which is improved in four respects: > - do not use spanned cells for width calculations > - draw horizontal rulers of the right width > - correctly draw horizontal frames > - guard against integer underflow in tbl_literal > > As explicit spacing options seem to be used very rarely, if at all, > i have left them out for now to not make the diff yet larger. > > OK? > Ingo Ingo, This looks ok---the table output formatting has always been spotty. Please check this in (I like the in-line documentation you have, but the more the better, as this area's tricksy). Thanks! Kristaps -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv