Re: mandocdb: do not use bogus files

[Kristaps Dzonsons <kristaps@bsd.lv>]

On 13/11/2011 19:42, Ingo Schwarze wrote:
> Hi,
>
> here is the first step towards usable titles in apropos(1) output.
>
> Currently, if you have a page /usr/share/man/man3p/FooBar::cAmEl.3p,
> you are quite lost, because apropos(1) will tell you
>
>    FOOBAR::CAMEL(3p) - my fancy Perl module
>
> but of course, this will not find the page:
>
>    man FOOBAR::CAMEL
>
> Also, imagine /usr/share/man/foobar/bogus.mdoc contained .Dt fancy 6,
> then apropos fancy would happily return
>
>    FANCY - my well hidden manual
>
> but of course man(1) will search for it in vain.
>
> Thus, only look for files in reasonable places, and save the filename
> stem (title), suffix (section), and architecture in the struct of,
> for later use by the indexer.
>
> OK?
>    Ingo

Ingo,

Yes, I like this as the default behaviour.  However, there must be a 
command-line flag not to do so, as I use mandocdb in my own directory 
structures.

You also need to free up the memory in ofile_free().

Furthermore, please amend mandocdb.8 to note which directories are 
visited and which are not (in the default case).  I also think it's a 
good idea to note skipped directories with a warning that's described in 
DIAGNOSTICS.  Since this is a .8, we should (in my humble opinion) be 
quite rigorous in what's done and what's not done.

Thoughts?

Kristaps
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv