Re: whatis(1)

[Kristaps Dzonsons <kristaps@bsd.lv>]

On 28/11/2011 01:35, Ingo Schwarze wrote:
> Hi Kristaps,
>
> Kristaps Dzonsons wrote on Sun, Nov 27, 2011 at 07:56:30PM +0100:
>
>> To get the ball rolling, I just checked in whatis.1 and the code
>> modified to use your regexp.  I simplified the call into
>> apropos_db.h with termcomp() instead of exprcomp(), as this mode
>> might be useful for man.cgi too.  The search expression is now case
>> insensitive and ~[[:<:]]term[[:>:]].  (Thanks!)
>
> I have merged this to OpenBSD, with a few tweaks, see below:
>
>   - One real bug: termcomp() returned the wrong end of the singly
>     linked list it built, such that only the last word given on
>     the command line was used.
>
>   - Whatever MacOS may be doing, i tweaked the the regex
>     from "Nm,Nd~" to "Nm~", which is current OpenBSD behaviour.
>     When we replace tools, we should not change behaviour at the
>     same time, but propose changes separately - if we want them.
>     In this case, i'm not even convinced the change makes sense.
>     If you ask "whatis mandoc", you clearly want "mandoc(1)" as
>     an answer; but why should you get "eqn(7), roff(7), tbl(7)"
>     as well?  That's, i think, what plain apropos(1) is for.
>     Maybe that's even a bug in MacOS?
>
>   - I suggest to check only the beginning of the command name,
>     such that you can e.g. install as "whatis.m" for testing
>     purposes.
>
> OK to commit these three tweaks to bsd.lv, too?

Great!  I prefer the `Nm' behaviour too; although I understand why Mac 
does it that way, I'm not convinced I like it yet.  Please update the 
whatis.1 manual, by the way, to note these changes.

Thanks,

Kristaps

--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv