From: Kristaps Dzonsons <kristaps@bsd.lv>
To: tech@mdocml.bsd.lv
Subject: Re: Do not cast void pointers to pointers requiring alignment.
Date: Tue, 20 Dec 2011 17:54:55 +0100 [thread overview]
Message-ID: <4EF0BDDF.2090003@bsd.lv> (raw)
In-Reply-To: <20111220164739.GA10043@iris.usta.de>
On 12/20/11 17:47, Ingo Schwarze wrote:
> Hi Kristaps,
>
> Kristaps Dzonsons wrote on Tue, Dec 20, 2011 at 11:58:07AM +0100:
>
>> Is it easier to apply this or wait for the patch being reviewed by
>> millert@? Whichever's more convenient for you.
>
> I guess i'll apply it unless millert@ provides feedback before
> we agree on it.
>
>> However, I don't like the assertions in this code. A bad database
>> shouldn't result in assertions (except the internal hashtable, as
>> it's a programmatic matter).
>
> I fully agree with that, but there are no assertions of the kind you
> seem to suspect.
>
>> All of these areas (index_prune(), index_read(), etc.), are built
>> with failure handlers when break;ing or return badly. Can you
>> modify the patch to use these instead?
>
> That's already the case.
Gah, you're absolutely right -- I didn't look closely enough. Thanks again!
--
To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv
prev parent reply other threads:[~2011-12-20 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 1:17 Ingo Schwarze
2011-12-20 10:58 ` Kristaps Dzonsons
2011-12-20 16:47 ` Ingo Schwarze
2011-12-20 16:54 ` Kristaps Dzonsons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF0BDDF.2090003@bsd.lv \
--to=kristaps@bsd.lv \
--cc=tech@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).