From: Kristaps Dzonsons <kristaps@bsd.lv>
To: tech@mdocml.bsd.lv
Subject: Re: Make the `-width' field to `Bl' not puke
Date: Sun, 15 Apr 2012 17:19:51 +0200 [thread overview]
Message-ID: <4F8AE717.4010005@bsd.lv> (raw)
In-Reply-To: <20120415104752.GA28604@iris.usta.de>
> This patch caused a regression in the following case,
> seen e.g. in fs(1):
>
> .Bl -tag -width -Fl -compact
>
> Correct behaviour is that -width and -offset consume the next
> argument even if it starts with a dash. By changing -width
> to OPT_SINGLE, the above case became "-width without argument",
> breaking the indentation.
>
> While merging your patch to OpenBSD, i fixed this by removing
> the dash check. Besides, ARGV_SINGLE turned out to be
> completely unused - .Bd -file errors out, anyway.
> Thus, i simply renamed opt_single to single and was able
> to delete a couple of lines of code.
>
> OK to commit to bsd.lv as well?
Hi Ingo,
In reading this (but not testing it right now), it looks like it'll work
fine in the event of `Bl -tag -width\n'; thus, it's fine by me. And it
cleans up that mess of special-case spaghetti: doubly ok!
Thanks,
Kristaps
--
To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv
next prev parent reply other threads:[~2012-04-15 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201203230550.q2N5oPkb028753@krisdoz.my.domain>
2012-04-15 10:47 ` Ingo Schwarze
2012-04-15 15:19 ` Kristaps Dzonsons [this message]
2012-04-15 15:27 ` Ingo Schwarze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8AE717.4010005@bsd.lv \
--to=kristaps@bsd.lv \
--cc=tech@mdocml.bsd.lv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).