From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-2.sys.kth.se (smtp-2.sys.kth.se [130.237.32.160]) by krisdoz.my.domain (8.14.5/8.14.5) with ESMTP id q3FFK3Ij027896 for ; Sun, 15 Apr 2012 11:20:03 -0400 (EDT) Received: from mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) by smtp-2.sys.kth.se (Postfix) with ESMTP id 041B914E80D for ; Sun, 15 Apr 2012 17:19:57 +0200 (CEST) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-2.sys.kth.se ([130.237.32.160]) by mailscan-1.sys.kth.se (mailscan-1.sys.kth.se [130.237.32.91]) (amavisd-new, port 10024) with LMTP id zphkUofkX4qk for ; Sun, 15 Apr 2012 17:19:55 +0200 (CEST) X-KTH-Auth: kristaps [193.10.49.5] X-KTH-mail-from: kristaps@bsd.lv X-KTH-rcpt-to: tech@mdocml.bsd.lv Received: from ctime.hhs.se (ctime.hhs.se [193.10.49.5]) by smtp-2.sys.kth.se (Postfix) with ESMTP id A030214E8AD for ; Sun, 15 Apr 2012 17:19:54 +0200 (CEST) Message-ID: <4F8AE717.4010005@bsd.lv> Date: Sun, 15 Apr 2012 17:19:51 +0200 From: Kristaps Dzonsons User-Agent: Mozilla/5.0 (X11; OpenBSD amd64; rv:5.0) Gecko/20110805 Thunderbird/5.0 X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 To: tech@mdocml.bsd.lv Subject: Re: Make the `-width' field to `Bl' not puke References: <201203230550.q2N5oPkb028753@krisdoz.my.domain> <20120415104752.GA28604@iris.usta.de> In-Reply-To: <20120415104752.GA28604@iris.usta.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > This patch caused a regression in the following case, > seen e.g. in fs(1): > > .Bl -tag -width -Fl -compact > > Correct behaviour is that -width and -offset consume the next > argument even if it starts with a dash. By changing -width > to OPT_SINGLE, the above case became "-width without argument", > breaking the indentation. > > While merging your patch to OpenBSD, i fixed this by removing > the dash check. Besides, ARGV_SINGLE turned out to be > completely unused - .Bd -file errors out, anyway. > Thus, i simply renamed opt_single to single and was able > to delete a couple of lines of code. > > OK to commit to bsd.lv as well? Hi Ingo, In reading this (but not testing it right now), it looks like it'll work fine in the event of `Bl -tag -width\n'; thus, it's fine by me. And it cleans up that mess of special-case spaghetti: doubly ok! Thanks, Kristaps -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv