tech@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: sternenseemann <sternenseemann@systemli.org>
To: tech@mandoc.bsd.lv
Subject: Re: [PATCH v2 makewhatis] refactor HOMEBREWDIR into READ_ALLOWED_PATH
Date: Sat, 7 Aug 2021 02:29:52 +0200	[thread overview]
Message-ID: <5671b9b1-35d9-a095-c44e-10e12ed6ad12@systemli.org> (raw)
In-Reply-To: <20210805123556.GA13788@athene.usta.de>

Hi Ingo,

On 8/5/21 2:35 PM, Ingo Schwarze wrote:
> Yes, i think so.  Besides, the start pointer wasn't advanced in the
> past with HOMEBREWDIR set, so i don't quite see why the present
> change should suddenly make it necessary.  Even if the pointer were
> used for something, stripping a directory that is not the basedir
> would seem wrong for any purpose because it would lose information.

Agreed.

> Other tweaks:
> …

Sounds very reasonable, thank you for adjusting the patch!

> Does this version work for you?

I did a normal rebuild of my db with this patch and everything seemed to
work fine, so that is a yes overall from my side!

> +# Nix package manager and/or NixOS Linux distibution:

Typo: should be distribution

> +# GNU Guix package manager and/or GNU Guix Linux distibution:

Same here.


Cheers,



  Lukas

--
 To unsubscribe send an email to tech+unsubscribe@mandoc.bsd.lv


  reply	other threads:[~2021-08-07  0:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30 19:49 [PATCH makewhatis] add NIXSTOREDIR configuration variable to support NixOS sternenseemann
2021-03-30 20:30 ` Ingo Schwarze
2021-03-30 21:03   ` sternenseemann
2021-03-31 17:34     ` Ingo Schwarze
2021-03-31 19:33       ` sternenseemann
2021-04-10 15:57       ` [PATCH v2 makewhatis] refactor HOMEBREWDIR into READ_ALLOWED_PATH sternenseemann
2021-04-10 16:15         ` sternenseemann
2021-08-03 16:42           ` sternenseemann
2021-08-05 12:35             ` Ingo Schwarze
2021-08-07  0:29               ` sternenseemann [this message]
2021-08-07 13:17                 ` Ingo Schwarze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5671b9b1-35d9-a095-c44e-10e12ed6ad12@systemli.org \
    --to=sternenseemann@systemli.org \
    --cc=tech@mandoc.bsd.lv \
    --subject='Re: [PATCH v2 makewhatis] refactor HOMEBREWDIR into READ_ALLOWED_PATH' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).