From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED
	autolearn=no autolearn_force=no version=3.4.4
Received: (qmail 12976 invoked from network); 7 Aug 2021 00:29:59 -0000
Received: from bsd.lv (HELO mandoc.bsd.lv) (66.111.2.12)
  by inbox.vuxu.org with ESMTPUTF8; 7 Aug 2021 00:29:59 -0000
Received: from fantadrom.bsd.lv (localhost [127.0.0.1])
	by mandoc.bsd.lv (OpenSMTPD) with ESMTP id b6092224
	for <ml@inbox.vuxu.org>;
	Fri, 6 Aug 2021 19:29:57 -0500 (EST)
Received: from mail1.systemli.org (mail1.systemli.org [212.103.72.247])
	by mandoc.bsd.lv (OpenSMTPD) with ESMTP id 5cb32ce3
	for <tech@mandoc.bsd.lv>;
	Fri, 6 Aug 2021 19:29:56 -0500 (EST)
Subject: Re: [PATCH v2 makewhatis] refactor HOMEBREWDIR into READ_ALLOWED_PATH
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=systemli.org;
	s=default; t=1628296194;
	bh=gswRxHXR5skH0RfHfpkDw396ct7hYnSwckNOUz6VU8A=;
	h=Subject:To:References:From:Date:In-Reply-To:From;
	b=9J3KDjtKPyU3HEirHbBbTzByYvevjrNEHpA1u93+6CLROihcBuXMoNvI2MYx+0mgJ
	 4DiIVu5pOaJQGCnmxbWlZBpriMqNcWQNb8DyeGCiDD4MoS74w+SHN8kPRod54zu9JV
	 wqYNsz+zh2MWpMZqrjwgrGePhuvvPVh67PDEP/mEIAj3X9osOK1recnVdDmwtz6dJk
	 JG8GTMYrXZWBiQ/za8tBJysYLUGXucH6qbrt1l2R8FNRPjn7I0J3v+BPtw7YGLzP4n
	 KEaCNxTlv3RRyLJVvwSTwCusShrmWPdtUseNLo+TQz/64aIF3OFWAggDzKTXg/zgPv
	 6jLoBx4mgyvwA==
To: tech@mandoc.bsd.lv
References: <8bce7cc9-954e-1c28-ee25-13969f66eb20@systemli.org>
 <20210330203020.GA94101@athene.usta.de>
 <060f9222-a388-a9fa-dc34-8f1981f8bf65@systemli.org>
 <20210331173434.GA57338@athene.usta.de>
 <3d224309-ff55-6354-8996-2c0e2b38f7a6@systemli.org>
 <991f74b2-499d-dafe-267b-f2ff5d64e4ee@systemli.org>
 <9353c0c4-83d9-ae57-0534-81cbcd65632e@systemli.org>
 <20210805123556.GA13788@athene.usta.de>
From: sternenseemann <sternenseemann@systemli.org>
Message-ID: <5671b9b1-35d9-a095-c44e-10e12ed6ad12@systemli.org>
Date: Sat, 7 Aug 2021 02:29:52 +0200
X-Mailinglist: mandoc-tech
Reply-To: tech@mandoc.bsd.lv
MIME-Version: 1.0
In-Reply-To: <20210805123556.GA13788@athene.usta.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

Hi Ingo,

On 8/5/21 2:35 PM, Ingo Schwarze wrote:
> Yes, i think so.  Besides, the start pointer wasn't advanced in the
> past with HOMEBREWDIR set, so i don't quite see why the present
> change should suddenly make it necessary.  Even if the pointer were
> used for something, stripping a directory that is not the basedir
> would seem wrong for any purpose because it would lose information.

Agreed.

> Other tweaks:
> …

Sounds very reasonable, thank you for adjusting the patch!

> Does this version work for you?

I did a normal rebuild of my db with this patch and everything seemed to
work fine, so that is a yes overall from my side!

> +# Nix package manager and/or NixOS Linux distibution:

Typo: should be distribution

> +# GNU Guix package manager and/or GNU Guix Linux distibution:

Same here.


Cheers,



  Lukas

--
 To unsubscribe send an email to tech+unsubscribe@mandoc.bsd.lv