tech@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: sternenseemann <sternenseemann@systemli.org>
To: tech@mandoc.bsd.lv
Subject: Re: makewhatis: segfault in dbadd when using -a
Date: Mon, 6 Sep 2021 17:52:48 +0200	[thread overview]
Message-ID: <6c8bb9c1-6d9e-b8f2-ba3f-7117c5fb8fe7@systemli.org> (raw)
In-Reply-To: <20210906145047.GC83680@athene.usta.de>

Hi Ingo,

On 9/6/21 16:50, Ingo Schwarze wrote:
> So, an acceptable way to support this probably exists, using the
> FTS_FOLLOW option of the function fts_set(3).  That isn't completely
> trivial in this code which is already somewhat convoluted, but it
> should not be excessively complicated either.

That's good to hear!

> Besides, i need to limit the difficulty of changes i'm doing right
> now or i will never get the next release out of the door.  So i
> decided to postpone this particular feature until after release,
> see the commit below.

That's no problem and I agree that it should probably be prioritize in 
this way. It only affects a few, albeit annoying cases and there is a 
reasonable workaround for it. Also I'm still (as far as I can tell) the 
only user of mandoc's whatis db on NixOS since I haven't yet gotten 
around to upstreaming my module / been waiting for a release.

Also one small clarification:

 > It doesn't matter that on first sight, this whole approach feels quite
 > fragile to me.  Isn't that going to blow up in horrible ways as soon as
 > somebody creates a package that also uses "man3p"?  For example, on
 > OpenBSD, "man3p" is used for manuals of Perl library functions.

The symlink manpath is immutable in NixOS, so it will be recreated from 
scratch if the list of installed packages changes. Thus this is not an 
issue.

Cheers, Lukas
--
 To unsubscribe send an email to tech+unsubscribe@mandoc.bsd.lv


  reply	other threads:[~2021-09-06 15:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06 23:53 sternenseemann
2021-08-11 15:09 ` Ingo Schwarze
2021-08-18 22:02   ` sternenseemann
2021-08-19 17:11     ` Ingo Schwarze
2021-09-06 14:50       ` Ingo Schwarze
2021-09-06 15:52         ` sternenseemann [this message]
2021-09-06 17:12           ` Ingo Schwarze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c8bb9c1-6d9e-b8f2-ba3f-7117c5fb8fe7@systemli.org \
    --to=sternenseemann@systemli.org \
    --cc=tech@mandoc.bsd.lv \
    --subject='Re: makewhatis: segfault in dbadd when using -a' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).