tech@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: Christian Neukirchen <chneukirchen@gmail.com>
To: Ingo Schwarze <schwarze@usta.de>
Cc: tech@mdocml.bsd.lv
Subject: Re: call for testing: mandoc-1.13.4 release candidate
Date: Sun, 10 Jul 2016 18:48:40 +0200	[thread overview]
Message-ID: <87h9bxiglz.fsf@gmail.com> (raw)
In-Reply-To: <20160710163617.GG14535@athene.usta.de> (Ingo Schwarze's message of "Sun, 10 Jul 2016 18:36:17 +0200")

Ingo Schwarze <schwarze@usta.de> writes:

> Hi Christian,
>
> Christian Neukirchen wrote on Sun, Jul 10, 2016 at 04:27:14PM +0200:
>
>> The RC works fine on Void Linux (glibc and musl) and addresses many
>> bugs found since the last release, thanks!
>
> Thanks for testing!
>
>> Two small nits:
>> 
>> - It would be nice to support the LDFLAGS variable in the Makefile
>
> What is that needed for?  I don't like adding gratuitious features
> and would prefer to understand the actual purpose in order to find
> a solution that is as simple as possible.

We build programs on Void using hardening, and need to pass special
linker flags for that (add RELRO and BIND_NOW).

>>   (soelim doesn't use any variable at all, else LDADD could be misused
>>   for that...)
>
> Maybe adding ${LDADD} to the soelim ${CC} line is a good solution?
> It may depend on what the actual problem is.

I can live with that.

Else we patch the Makefile, not a big deal either.

>> - It would be nice to make the default MANPAGER configurable at
>>   compile time, since more(1) on non-BSD systems is an unusable
>>   default (no back scrolling etc.)
>
> Hmm, POSIX slightly favours having more(1) as the default in man(1)
> but explicitly allows a system to use a different pager by default.
> So maybe.  But implementing it is a bit of a bother because it
> requires patching the file man.1 at configuration time.  I'm not
> sure yet whether i want to do that.  I won't do it for the 1.13.4
> release, it would be too intrusive at this point.

Perhaps a macro could be used to refer to the default pager, then you
just need to change one line?

> If you prepare a port for an operating system where the system more(1)
> is unusable, i'd recommend adding local patches to the appropriate
> places in main.c and man.1 for now.

I currently use

        sed -i 's,bin/more,bin/less,g' main.c *.1
        sed -i 's,.Xr more,.Xr less,g' *.1
        sed -i 's,"more","less",g' manpage.c

Thanks,
-- 
Christian Neukirchen  <chneukirchen@gmail.com>  http://chneukirchen.org
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv

  reply	other threads:[~2016-07-10 16:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <sfid-H20160709-151232-+015.17-1@spamfilter.osbf.lua>
     [not found] ` <20160709131158.GA6629@athene.usta.de>
2016-07-09 13:18   ` Thomas Klausner
2016-07-09 15:30     ` Ingo Schwarze
2016-07-09 13:39   ` Baptiste Daroussin FreeBSD
2016-07-09 14:31     ` Anthony J. Bentley
2016-07-09 15:29       ` New db format (was Re: call for testing: mandoc-1.13.4 release candidate) Baptiste Daroussin
2016-07-09 16:12         ` New db format Ingo Schwarze
2016-08-05 20:26           ` Baptiste Daroussin
2016-07-09 14:28   ` call for testing: mandoc-1.13.4 release candidate Svyatoslav Mishyn Crux
2016-07-10 14:08     ` Ingo Schwarze
2016-07-09 18:21   ` Svyatoslav Mishyn
2016-07-09 21:13     ` Ingo Schwarze
2016-07-09 18:55   ` Svyatoslav Mishyn Crux
2016-07-10 10:46     ` Svyatoslav Mishyn
2016-07-10 13:39       ` Ingo Schwarze
2016-07-10 14:27   ` Christian Neukirchen
2016-07-10 16:36     ` Ingo Schwarze
2016-07-10 16:48       ` Christian Neukirchen [this message]
2016-07-10 18:34         ` Ingo Schwarze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h9bxiglz.fsf@gmail.com \
    --to=chneukirchen@gmail.com \
    --cc=schwarze@usta.de \
    --cc=tech@mdocml.bsd.lv \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).