mdocml fix for .PD

mdocml fix for .PD

[Christian Neukirchen]

Hi,

I'm not exactly sure about the semantics of .PD, but applying the
following affects 29 of 12419 manpages on my system, and in each case
the new version looks as it's meant to be.  It now renders like
Groff 1.22.3 and Plan9 nroff.

In particular this fixes:

  cscope.1 gawk.1 ksh.1 qrencode.1 tcsh.1 xargs.1 zip.1 zipcloak.1 zsh.1
  zshall.1 zshbuiltins.1 zshcalsys.1 zshcompctl.1 zshcompsys.1
  zshcompwid.1 zshcontrib.1 zshexpn.1 zshmisc.1 zshmodules.1
  zshoptions.1 zshparam.1 zshroadmap.1 zshtcpsys.1 zshzftpsys.1 zshzle.1
  elf.5 nsswitch.conf.5 nmh.7 chcpu.8

--- man_macro.c	2015-03-13 13:38:38.000000000 +0100
+++ man_macro.c	2015-03-19 23:20:11.786601197 +0100
@@ -79,7 +79,7 @@
 	{ blk_exp, MAN_BSCOPE | MAN_EXPLICIT }, /* RS */
 	{ in_line_eoln, 0 }, /* DT */
 	{ in_line_eoln, 0 }, /* UC */
-	{ in_line_eoln, 0 }, /* PD */
+	{ in_line_eoln, MAN_BSCOPE }, /* PD */
 	{ in_line_eoln, 0 }, /* AT */
 	{ in_line_eoln, 0 }, /* in */
 	{ in_line_eoln, 0 }, /* ft */

hth,
-- 
Christian Neukirchen  <chneukirchen@gmail.com>  http://chneukirchen.org
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv

Re: mdocml fix for .PD

[Ingo Schwarze]

Hi Christian,

Christian Neukirchen wrote on Fri, Mar 20, 2015 at 11:29:40AM +0100:

> I'm not exactly sure about the semantics of .PD, but applying the
> following

That patch is clearly wrong.  For example, it breaks the following
OpenBSD regression test:

  /usr/src/regress/usr.bin/mandoc/man/PD/nextline.in

Basically, it breaks anything that contains .PD after .TP or
.TP after .SH or .SS without arguments, that is, .TP after the block
macros that can have next-line head scope.  The .PD macro is _not_
supposed to break block scope.

> affects 29 of 12419 manpages on my system, and in each case
> the new version looks as it's meant to be.  It now renders like
> Groff 1.22.3 and Plan9 nroff.
> 
> In particular this fixes:
> 
>   cscope.1 gawk.1 ksh.1 qrencode.1 tcsh.1 xargs.1 zip.1 zipcloak.1 zsh.1
>   zshall.1 zshbuiltins.1 zshcalsys.1 zshcompctl.1 zshcompsys.1
>   zshcompwid.1 zshcontrib.1 zshexpn.1 zshmisc.1 zshmodules.1
>   zshoptions.1 zshparam.1 zshroadmap.1 zshtcpsys.1 zshzftpsys.1 zshzle.1
>   elf.5 nsswitch.conf.5 nmh.7 chcpu.8

I'm not sure which system you are talking about - some Linux?

Is the problem with these pages still present in mandoc -HEAD,
or is it fixed after my recent commit?  Please make sure you
have man_macro.c rev. 1.100 from mdocml.bsd.lv or man_macro.c
rev. 1.62 from OpenBSD when retesting.

Thanks,
  Ingo

> --- man_macro.c	2015-03-13 13:38:38.000000000 +0100
> +++ man_macro.c	2015-03-19 23:20:11.786601197 +0100
> @@ -79,7 +79,7 @@
>  	{ blk_exp, MAN_BSCOPE | MAN_EXPLICIT }, /* RS */
>  	{ in_line_eoln, 0 }, /* DT */
>  	{ in_line_eoln, 0 }, /* UC */
> -	{ in_line_eoln, 0 }, /* PD */
> +	{ in_line_eoln, MAN_BSCOPE }, /* PD */
>  	{ in_line_eoln, 0 }, /* AT */
>  	{ in_line_eoln, 0 }, /* in */
>  	{ in_line_eoln, 0 }, /* ft */
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv

Re: mdocml fix for .PD

[Christian Neukirchen]

Ingo Schwarze <schwarze@usta.de> writes:

> Is the problem with these pages still present in mandoc -HEAD,
> or is it fixed after my recent commit?  Please make sure you
> have man_macro.c rev. 1.100 from mdocml.bsd.lv or man_macro.c
> rev. 1.62 from OpenBSD when retesting.

Your change in 1.100 fixed this already.  Thanks.
-- 
Christian Neukirchen  <chneukirchen@gmail.com>  http://chneukirchen.org
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv

mdocml fix for .PD

[Christian Neukirchen]

Hi,

I'm not exactly sure about the semantics of .PD, but applying the
following affects 29 of 12419 manpages on my system, and in each case
the new version looks as it's meant to be.  It now renders like
Groff 1.22.3 and Plan9 nroff.

In particular this fixes:

  cscope.1 gawk.1 ksh.1 qrencode.1 tcsh.1 xargs.1 zip.1 zipcloak.1 zsh.1
  zshall.1 zshbuiltins.1 zshcalsys.1 zshcompctl.1 zshcompsys.1
  zshcompwid.1 zshcontrib.1 zshexpn.1 zshmisc.1 zshmodules.1
  zshoptions.1 zshparam.1 zshroadmap.1 zshtcpsys.1 zshzftpsys.1 zshzle.1
  elf.5 nsswitch.conf.5 nmh.7 chcpu.8

--- man_macro.c	2015-03-13 13:38:38.000000000 +0100
+++ man_macro.c	2015-03-19 23:20:11.786601197 +0100
@@ -79,7 +79,7 @@
 	{ blk_exp, MAN_BSCOPE | MAN_EXPLICIT }, /* RS */
 	{ in_line_eoln, 0 }, /* DT */
 	{ in_line_eoln, 0 }, /* UC */
-	{ in_line_eoln, 0 }, /* PD */
+	{ in_line_eoln, MAN_BSCOPE }, /* PD */
 	{ in_line_eoln, 0 }, /* AT */
 	{ in_line_eoln, 0 }, /* in */
 	{ in_line_eoln, 0 }, /* ft */

hth,
-- 
Christian Neukirchen  <chneukirchen@gmail.com>  http://chneukirchen.org
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv