From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.4 Received: (qmail 20128 invoked from network); 3 Aug 2021 16:42:19 -0000 Received: from bsd.lv (HELO mandoc.bsd.lv) (66.111.2.12) by inbox.vuxu.org with ESMTPUTF8; 3 Aug 2021 16:42:19 -0000 Received: from fantadrom.bsd.lv (localhost [127.0.0.1]) by mandoc.bsd.lv (OpenSMTPD) with ESMTP id 630ace5c for ; Tue, 3 Aug 2021 11:42:17 -0500 (EST) Received: from mail1.systemli.org (mail1.systemli.org [212.103.72.247]) by mandoc.bsd.lv (OpenSMTPD) with ESMTP id 5bdc15ea for ; Tue, 3 Aug 2021 11:42:16 -0500 (EST) Subject: Re: [PATCH v2 makewhatis] refactor HOMEBREWDIR into READ_ALLOWED_PATH DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=systemli.org; s=default; t=1628008934; bh=B3b3P3TBCN7+a0HOH0J8b+jNz/qIGrs/x0S6bpfBCbQ=; h=Subject:From:To:Reply-To:References:Date:In-Reply-To:From; b=011d7de9D8FH5sSiZioHR8UpAUtx8ZDjl1sb4nPYDo2SipczEvZWDcLJsYssx3z/7 FfHFOw/r3gI+Z7Jny5Pt56L2N1Axn4i0QgLtNuwIbdziPWrxV5O8F3x+Qku161v8GI 0E+0JD65uh/xsdjFvwTwX90mzMyEMDLY5qpzhChlkuXNYLteY1+UWWkXwQnNmH4CLV E3ULDdK3eBd8G6ZBcbrPIZ8G1D1ZrjR6gMnhLuq4JOM+yd3a4LjRHSk65CFKMrGeWy U2c6vwma+rG7t4RTYtzLw1HNUwHW7VXMhUsmCxiXGWUJVeZK6TJZIcjw8f5Sxq5gHV 1pm0yhNFY/lsQ== From: sternenseemann To: tech@mandoc.bsd.lv Reply-To: tech@mandoc.bsd.lv References: <8bce7cc9-954e-1c28-ee25-13969f66eb20@systemli.org> <20210330203020.GA94101@athene.usta.de> <060f9222-a388-a9fa-dc34-8f1981f8bf65@systemli.org> <20210331173434.GA57338@athene.usta.de> <3d224309-ff55-6354-8996-2c0e2b38f7a6@systemli.org> <991f74b2-499d-dafe-267b-f2ff5d64e4ee@systemli.org> Message-ID: <9353c0c4-83d9-ae57-0534-81cbcd65632e@systemli.org> Date: Tue, 3 Aug 2021 18:42:13 +0200 X-Mailinglist: mandoc-tech Reply-To: tech@mandoc.bsd.lv MIME-Version: 1.0 In-Reply-To: <991f74b2-499d-dafe-267b-f2ff5d64e4ee@systemli.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ingo, just wanted to bump this thread since it is still important to me. I'd be happy to make any adjustments as well as implement review suggestions. So if you have time for a review, that'd be great! On 4/10/21 6:15 PM, sternenseemann wrote: > Hm, this is kinda unnecessary, is it? start will be set again for all > files which are symlinks, so this value will never get used right? Also could you confirm this for me? If true, I think I can make the patch a bit simpler by making read_allowed just return 0 or 1. Cheers, Lukas -- To unsubscribe send an email to tech+unsubscribe@mandoc.bsd.lv