From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.4 Received: (qmail 24870 invoked from network); 10 Apr 2021 16:15:26 -0000 Received: from bsd.lv (HELO mandoc.bsd.lv) (66.111.2.12) by inbox.vuxu.org with ESMTPUTF8; 10 Apr 2021 16:15:26 -0000 Received: from fantadrom.bsd.lv (localhost [127.0.0.1]) by mandoc.bsd.lv (OpenSMTPD) with ESMTP id 919866eb for ; Sat, 10 Apr 2021 11:15:21 -0500 (EST) Received: from mail1.systemli.org (mail1.systemli.org [212.103.72.247]) by mandoc.bsd.lv (OpenSMTPD) with ESMTP id 00e55cb2 for ; Sat, 10 Apr 2021 11:15:19 -0500 (EST) Subject: Re: [PATCH v2 makewhatis] refactor HOMEBREWDIR into READ_ALLOWED_PATH DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=systemli.org; s=default; t=1618071317; bh=7/7a8i5CMKAkS2/JSYjU0buEuYj1jlkwmwDPqeyok2Y=; h=Subject:From:To:Reply-To:References:Date:In-Reply-To:From; b=10l/WUAXt6RbM9oW+FWn4NaGxzt19ij8Yv2N27FOQWUNgK5zjoIOzwe0kV5333GC4 Y2krVMn904CIUHzqMv684DYNbau8IjOn6ci4OQ61ElWjyhxNu7wS9gdImHjQMIvhHw 11eI3WqsGF3ntOstvKcWBr4U6z3nev7BcVl5Qc521yFYwWqZ3Drnfs+hgVttKNKViQ JuTBYjDGUSw2wpPUu9zBwaEKhN3YudItLGu2ipvlcz/1AlCNKlQlpDNJG+o6jfHqAU gsyZ+aXHQmYmnABuPbSeBhInnLV13Cb3LnGqNC2BYw3zDwPWboHxKE+DKTvGTUHb4B hkAmroFx/FGnA== From: sternenseemann To: tech@mandoc.bsd.lv Reply-To: tech@mandoc.bsd.lv References: <8bce7cc9-954e-1c28-ee25-13969f66eb20@systemli.org> <20210330203020.GA94101@athene.usta.de> <060f9222-a388-a9fa-dc34-8f1981f8bf65@systemli.org> <20210331173434.GA57338@athene.usta.de> <3d224309-ff55-6354-8996-2c0e2b38f7a6@systemli.org> Message-ID: <991f74b2-499d-dafe-267b-f2ff5d64e4ee@systemli.org> Date: Sat, 10 Apr 2021 18:15:15 +0200 X-Mailinglist: mandoc-tech Reply-To: tech@mandoc.bsd.lv MIME-Version: 1.0 In-Reply-To: <3d224309-ff55-6354-8996-2c0e2b38f7a6@systemli.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/10/21 5:57 PM, sternenseemann wrote: > The previous checks on basedir and HOMEBREWDIR if defined have been > refactored into a function called read_allowed which also tracks the > length of the allowed dir which allows us to at least strip the prefix > from READ_ALLOWED_PATHS in filescan (this wasn't done previously for > HOMEBREWDIR). Hm, this is kinda unnecessary, is it? start will be set again for all files which are symlinks, so this value will never get used right? -- To unsubscribe send an email to tech+unsubscribe@mandoc.bsd.lv