From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi0-f43.google.com (mail-oi0-f43.google.com [209.85.218.43]) by fantadrom.bsd.lv (OpenSMTPD) with ESMTP id c988c554 for ; Thu, 7 Apr 2016 12:38:44 -0500 (EST) Received: by mail-oi0-f43.google.com with SMTP id s79so107971267oie.1 for ; Thu, 07 Apr 2016 10:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to; bh=lh25jv+7syS0G5vCU86qOEXKyjxM69nqRXQ2pFcD/3A=; b=aKRDfUzWnl1blKNn4SwkAusRGWvpzrzBTdp/kAPVGva74KaFU3kD9Wah/pqz17puy3 eTCHUFASqBvyxlv2VOVI1TnlTQ+Z/MD6PRLiXHKOnpzxCBcHjOnUuEBMFg4jONMFjvgE amY/MtvrvKtkgf1GrYpCPsYxH4+YF2gvol4ArdX7V2+J/WoZz3txMotnkANUlmwoWf42 bG/YYDc7nE4y7M1T+0foGCfYsIzNgaogAI3hKbSVqDfWOFyV1OF043JfiJAs0Nx+fszN xF/vW+eEDykoBDB+v3pApon8XTv6xBA0+dh6rwD5tusqVzgwiSlwsu71CUJESGsRn2KX gQ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to; bh=lh25jv+7syS0G5vCU86qOEXKyjxM69nqRXQ2pFcD/3A=; b=B5akGqi/EkkJd35ZCLgo/LAkkUPW0b2ON3ebXkGtHv1miDa4YvK4rpQ9Ga0gr80U0Q Jfrb5J6LCwKBmJofKJED0mU9db+9rzTmM4kE5jTCz71ZWPNX/+r+r7jfqvb1QFOactWn kMZgjnAbCGoGzdKZwASsTza1ZkvGCkCsaNxipQ8Sy1xDEwdp3aa+CzY+i1MCAxXefjDQ OwkwCw7s4UUufmfdPaXEQBDoNRcPreuBrYfCECcIaZp0jRmz/sToPBksqlRuqGmsHqQg J2asVDEavfzyd/HzRh4pLQAua2tiXI1MiQHROT8bsvzpvNSvWzr5GnCQxJAmPQVONnfP sn1g== X-Gm-Message-State: AD7BkJJ1mQyRuPF1n0gi6afkPEQLImqAGp3rjcxjhvwqkHU5JdQrl/rjJmsGfLQJMPt/3XOXrKsRAsNvLDEt3w== X-Mailinglist: mdocml-tech Reply-To: tech@mdocml.bsd.lv MIME-Version: 1.0 X-Received: by 10.202.183.7 with SMTP id h7mr2110633oif.25.1460050722067; Thu, 07 Apr 2016 10:38:42 -0700 (PDT) Received: by 10.157.15.173 with HTTP; Thu, 7 Apr 2016 10:38:42 -0700 (PDT) Date: Thu, 7 Apr 2016 23:08:42 +0530 Message-ID: Subject: Possible Memory leak in mdoc_validate.c? From: Abhinav Upadhyay To: tech@mdocml.bsd.lv Content-Type: text/plain; charset=UTF-8 Hi, The function post_os in mdoc_validate.c has a static char *defbuf, which doesn't seem to be free'd after allocation. Shouldn't it be free'd and set to NULL if it was allocated? On Linux, valgrind was reporting a warning that the memory allocated here was still reachable, the following change got rid of that warning for me. Index: dist/mdoc_validate.c =================================================================== RCS file: /cvsroot/src/external/bsd/mdocml/dist/mdoc_validate.c,v retrieving revision 1.9 diff -u -r1.9 mdoc_validate.c --- dist/mdoc_validate.c 7 Jan 2016 20:05:41 -0000 1.9 +++ dist/mdoc_validate.c 3 Apr 2016 11:51:09 -0000 @@ -2289,6 +2289,10 @@ utsname.sysname, utsname.release); } mdoc->meta.os = mandoc_strdup(defbuf); + if (NULL != defbuf) { + free(defbuf); + defbuf = NULL; + } #endif /*!OSNAME*/ out: -- To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv