Re: mlist to list DT_LNK elements

Re: mlist to list DT_LNK elements

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/172#issuecomment-596090783

Comment:
Note that `mu find --fields l` will just output the file name, then you can just use them as a sequence.
(That's how I use mairix.) (Also see contrib/msearch.)

If we're going to allow DT_LNK, code also needs changing in `namescan` and `iterdir`.

Re: mlist to list DT_LNK elements

[eiro]

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

New comment by eiro on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/172#issuecomment-596092852

Comment:
> Note that `mu find --fields l` will just output the file name, then
> you can just use them as a sequence.

the thing is i see no reason to not support DT_LNK and there are plenty
of possible usages.

> (That's how I use mairix.) (Also see contrib/msearch.)

i would be curious about the reasons you chosen mairix. is there another
channel to ask about it? (mailing list or something?)

> If we're going to allow DT_LNK, code also needs changing in `namescan` and `iterdir`

if you like the idea, i would be happy to ammend the PR until it will
please you.

regards
marc

Re: mlist to list DT_LNK elements

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/172#issuecomment-596096458

Comment:
Mostly because mairix was around long before mu, also it's indexes are way smaller (but it has other limitations.)

I can adapt the patch myself, thanks. I'll get around to it in the next few days.

Re: mlist to list DT_LNK elements

[eiro]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

New comment by eiro on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/172#issuecomment-596098965

Comment:
On Sat, Mar 07, 2020 at 06:53:02AM -0800, Leah Neukirchen wrote:
> Mostly because mairix was around long before mu, also it's indexes are way smaller (but it has other limitations.)

thanks for this reply

> I can adapt the patch myself, thanks. I'll get around to it in the next few days.

ok. it's probably faster for you to edit your code than doing review.

thanks a lot

Re: mlist to list DT_LNK elements

[eiro]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

New comment by eiro on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/172#issuecomment-596178670

Comment:
i would had introduced something like

        #if defined(DT_REG) && defined(DT_LNK) && defined(DT_UNKNOWN)
        #define IS_LEGIT_DT(t) (t != DT_REG && t != DT_LNK && t != DT_UNKNOWN)
        #else
        #define IS_LEGIT_DT(t) (1)
        #endif

in a file like config.h and then add some other generic macros and
configuration like

        #if defined(__linux__)
        #define __GNU_SOURCE__
        #endif

        #define uc ...
        #define lc ...

regards
marc